[6.x] Settings Index page #18183
Draft
[6.x] Settings Index page #18183
+789
−346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ftcms/cms into feature/inertia-settings-index
…ftcms/cms into feature/inertia-settings-index
riasvdv
reviewed
Dec 17, 2025
brianjhanson
commented
Dec 17, 2025
src/Cp/Settings.php
Outdated
Comment on lines
105
to
113
| // @TODO ask Rias for help with this | ||
| // // Fire a 'registerCpSettings' event | ||
| // $eventName = $readOnly ? self::EVENT_REGISTER_READ_ONLY_CP_SETTINGS : self::EVENT_REGISTER_CP_SETTINGS; | ||
| // if ($this->hasEventHandlers($eventName)) { | ||
| // $event = new RegisterCpSettingsEvent(['settings' => $settings]); | ||
| // $this->trigger($eventName, $event); | ||
| // | ||
| // return $event->settings; | ||
| // } |
Contributor
Author
There was a problem hiding this comment.
@riasvdv Can you remind me how I should be implementing events so both Yii and Laravel events work properly? Or maybe just point me towards an example?
Contributor
There was a problem hiding this comment.
-
Create new events RegisterReadonlyCpSettings and RegisterCpSettings
-
Add a static
registerEvents()to the legacy class that used to dispatch them, where it listens for the new event and dispatches that in the Yii way. -
Add a call to that static method in the service provider of the adapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeting the
refactor-t-functionbranch just for a cleaner diff.Moves the main settings page into inertia. The main change here is setting up at least a first pass of our icon library to use with the
craft-iconcomponent (which is just a wrapper aroundwa-icon).Warning
I updated where assets are published which may break things for you.
Previously we published the
resources/buildfolder topublic/vendor/craftbut now that we're also publishing icons, those have been moved topublic/vendor/craft/build. Icons will end up inpublic/vendor/craft/icons.I know at least @riasvdv and I have symlinks set up that links
public/vendor/crafttoresources/build. With this PR you'll need to update that. In my case I just symlinked the entireresourcesdirectory.