Skip to content

Fix tag invalidation from CLI #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2025
Merged

Fix tag invalidation from CLI #71

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68d638e
Change log level
timkelty Feb 15, 2025
68394c8
Map tag to string to work around Laravel bug
timkelty Feb 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/StaticCache.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ private function addCacheHeadersToWebResponse(): void
$this->tags->push(...$existingTagsFromHeader);
$this->tags = $this->prepareTags(...$this->tags);

Craft::warning(new PsrMessage('Adding cache tags to response', [
Craft::info(new PsrMessage('Adding cache tags to response', [
'tags' => $this->tags,
]));

Expand Down Expand Up @@ -294,7 +294,8 @@ public function purgeTags(string|StaticCacheTag ...$tags): void

// TODO: make sure we don't go over max header size
Helper::makeGatewayApiRequest([
HeaderEnum::CACHE_PURGE_TAG->value => $tags->implode(','),
// Mapping to string because: https://github.com/laravel/framework/pull/54630
HeaderEnum::CACHE_PURGE_TAG->value => $tags->map(fn(StaticCacheTag $tag) => (string) $tag)->implode(','),
]);
}

Expand Down
Loading