Skip to content

Conversation

@i-just
Copy link
Contributor

@i-just i-just commented Sep 9, 2025

Description

Follow up to #434 and #459.

434 fixed a bug where the “Heading Levels” setting wasn’t fully respected and could be overwritten via “Config Options”.
459 allowed for custom heading elements to be provided via “Config Options”

This PR fixes a bug where:

  • if you selected h1 and h2 under “Heading Levels” and then provided a custom config for them via “Config Options” (e.g. changed the title or added classes), that custom config wasn’t respected
  • if you selected h1 and h2 under “Heading Levels” and then provided a custom config for only one of them via “Config Options”, the other heading wasn’t showing as a dropdown option

Related issues

#461

@i-just i-just requested a review from brandonkelly as a code owner September 9, 2025 10:45
@i-just i-just changed the base branch from 4.x to 3.x September 9, 2025 10:45
@jamiepittock
Copy link

@i-just can you please bump this a review and merge please?

@jrrdnx
Copy link

jrrdnx commented Nov 13, 2025

Any update on this getting merged? This is currently a roadblock for several time-sensitive projects for us.

@brandonkelly brandonkelly merged commit 0ea0abb into 3.x Nov 15, 2025
4 checks passed
@brandonkelly brandonkelly deleted the bugfix/461-custom-heading-config branch November 15, 2025 01:02
brandonkelly added a commit that referenced this pull request Nov 15, 2025
brandonkelly added a commit that referenced this pull request Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants