Feature/expand entry buttons setting #413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/web/assets/ckeditor/dist/ckeditor5-craftcms.js # src/web/assets/ckeditor/dist/ckeditor5-craftcms.js.map
brandonkelly
force-pushed
the
feature/expand-entry-buttons-setting
branch
from
fd87837 to
4461f95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
expandEntryButtonsproperty to the CKEditor field, which allows you to control whether you want to switch to the “new” entry type buttons.If turned off (default), the “old” button (single “+” button that triggers a dropdown with all the entry types selected for the field) is shown.
In this case, you can also customise the label of the button (like you could before).If turned on, the entry types that have icons have separate buttons (with colour, if selected for the entry type), with the rest going into the “+” dropdown (as per #404).
I also switched the translation category for
"New <entryTypeLabel>"fromapptockeditorso there’s greater control over how the button tooltips are translated.Related issues
#406
#404