Skip to content

Window monacoeditor instances #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandonkelly merged 3 commits into from
Apr 30, 2025
Merged

Window monacoeditor instances #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d976525
Explicit dependency on CodeEditorAsset
brianjhanson Apr 29, 2025
534390f
Optimize imports
brianjhanson Apr 29, 2025
8fcfa76
Release note
brandonkelly Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
- Added `craft\ckeditor\gql\CkeditorMarkup`.
- Added `craft\ckeditor\gql\Generator`.
- Fixed a bug where it wasn’t easily possible to drag a toolbar button to the last position in the toolbar, if that meant wrapping the buttons to a new row.
- Fixed a JavaScript error that could prevent the toolbar configurator from loading, when editing a CKEditor config within a slideout. ([#401](https://github.com/craftcms/ckeditor/pull/401))

## 4.7.0 - 2025-04-21

Expand Down
2 changes: 2 additions & 0 deletions src/web/assets/ckeconfig/CkeConfigAsset.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

use craft\ckeditor\web\assets\ckeditor\CkeditorAsset;
use craft\web\AssetBundle;
use nystudio107\codeeditor\assetbundles\codeeditor\CodeEditorAsset;

/**
* CKEditor custom build asset bundle
Expand All @@ -26,6 +27,7 @@ class CkeConfigAsset extends AssetBundle
* @inheritdoc
*/
public $depends = [
CodeEditorAsset::class,
CkeditorAsset::class,
];

Expand Down