Trashed Nested Entries get added during Matrix to CKEditor migration

[rungta]

Description

While converting some matrix fields to CKEditor, I noticed some nested entries being duplicated. On investigating further, it looked like certain trashed entries were being re-added to the content. Poked around the migration code and this criteria in the nested entries query seems to be the culprit.

ckeditor/src/migrations/BaseConvertMatrixContentMigration.php

Line 87 in 6619d08

->trashed(null)

Steps to reproduce

1. Create a matrix field with at least one entry type (A) with a CKEditor field, and one or more additional entry types
2. Add some blocks/entries
3. Delete a few blocks
4. Convert this matrix field to a CKEditor field and use the (A) entry type for the base HTML content
5. The deleted blocks should re-appear in the content

Additional info

• Craft version: 5.8.6
• PHP version: 8.2
• Database driver & version: MariaDB
• Plugins & versions: 4.10.1

[linear]

PT-2896 Trashed Nested Entries get added during Matrix to CKEditor migration

[i-just]

Hi, thanks for reporting! I raised a PR for this.

[brandonkelly]

CKEditor 4.11.0 is out with a fix for this. Thanks again!