Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #99. This commit changes the backend from the
python-midi
package tomido
. This change was tested by reading in 1,000 MIDI files withpretty_midi
with both backends, writing them out, and then comparing md5 checksums of the written files. This tests both parsing and writing, which are the two things the backend is used for. The known differences arepretty_midi
.mido
rightfully rounds microseconds per quarter note in its BPM calculations,midi
doesn't. To maintain backwards compatibility, I am not usingmido
's functionality for this, but I will soon. This will break backwards compatibility (and change timing on the sub-microsecond scale).@douglaseck, @cghawthorne can you run this code through your test suite to see if anything breaks before I merge and make a new release?