Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote print errors handling #422

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Conversation

sinandev
Copy link
Contributor

Added XmlHttpRequest error event handler.
On remote print errors such as could not find the url. PrintJS does not handle the error

On remote print errors such as could not find the url. PrintJS does not handle the error
@crabbly
Copy link
Owner

crabbly commented Sep 16, 2020

Hey @sinandev, thank you so much for helping with the library. Sorry for the delay on this btw.
I like the idea, we should definitely handle these errors. Using the user callback input is perfect. Thanks again!

@crabbly crabbly merged commit 061d1a4 into crabbly:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants