Updated 28032019

.circleci/config.yml

@@ -37,6 +37,12 @@ reusable-steps:
         - php-cs-fixer-cache-{{ .Revision }}
         - php-cs-fixer-cache-{{ .Branch }}
         - php-cs-fixer-cache
+  - &restore-phpstan-cache
+    restore_cache:
+      keys:
+        - phpstan-cache-{{ .Revision }}
+        - phpstan-cache-{{ .Branch }}
+        - phpstan-cache
   - &save-composer-cache-by-branch
     save_cache:
       paths:
@@ -67,6 +73,16 @@ reusable-steps:
       paths:
         - .php_cs.cache
       key: php-cs-fixer-cache-{{ .Revision }}-{{ .BuildNum }}
+  - &save-phpstan-cache-by-branch
+    save_cache:
+      paths:
+        - /tmp/phpstan/cache
+      key: phpstan-cache-{{ .Branch }}-{{ .BuildNum }}
+  - &save-phpstan-cache-by-revision
+    save_cache:
+      paths:
+        - /tmp/phpstan/cache
+      key: phpstan-cache-{{ .Revision }}-{{ .BuildNum }}
   - &update-composer
     run:
       name: Update Composer
@@ -106,25 +122,27 @@ jobs:
   phpstan:
     docker:
       - image: circleci/php:7.2-node-browsers
+    environment:
+      # https://github.com/phpstan/phpstan-symfony/issues/37
+      APP_DEBUG: 1
     working_directory: ~/api-platform/core
     steps:
       - checkout
       - *restore-composer-cache
+      - *restore-phpstan-cache
       - *disable-xdebug-php-extension
       - *disable-php-memory-limit
       - *install-php-extensions
       - *update-composer
       - *update-project-dependencies
-      - run:
-          name: Install PHPStan
-          command: composer global require phpstan/phpstan:0.10.5
       - *save-composer-cache-by-revision
       - *save-composer-cache-by-branch
+      - *clear-test-app-cache
       - run:
           name: Run PHPStan
-          command: |-
-            export PATH="$PATH:$HOME/.composer/vendor/bin"
-            phpstan analyse -c phpstan.neon -l6 --ansi src tests
+          command: vendor/bin/phpstan analyse --ansi
+      - *save-phpstan-cache-by-revision
+      - *save-phpstan-cache-by-branch
 
   phpunit-coverage:
     docker:
@@ -195,7 +213,7 @@ jobs:
           name: Run Behat tests
           command: |-
             mkdir -p build/logs/tmp build/cov
-            for f in $(find features -name '*.feature' -not -path 'features/main/exposed_state.feature' -not -path 'features/elasticsearch/*' | circleci tests split --split-by=timings); do
+            for f in $(find features -name '*.feature' -not -path 'features/main/exposed_state.feature' -not -path 'features/elasticsearch/*' -not -path 'features/mongodb/*' | circleci tests split --split-by=timings); do
               _f=${f//\//_}
               FEATURE="${_f}" phpdbg -qrr vendor/bin/behat --profile=coverage --suite=default --format=progress --out=std --format=junit --out=build/logs/tmp/"${_f}" "$f"
             done

.editorconfig

@@ -26,6 +26,10 @@ indent_size = 2
 [*.md]
 trim_trailing_whitespace = false
 
+[*.neon]
+indent_style = tab
+indent_size = 4
+
 [*.php]
 indent_style = space
 indent_size = 4
@@ -62,14 +66,18 @@ indent_size = 2
 indent_style = space
 indent_size = 2
 
-[behat.yml]
+[behat.yml{,.dist}]
 indent_style = space
 indent_size = 2
 
 [composer.json]
 indent_style = space
 indent_size = 4
 
-[phpunit.xml.dist]
+[phpstan.neon{,.dist}]
+indent_style = tab
+indent_size = 4
+
+[phpunit.xml{,.dist}]
 indent_style = space
 indent_size = 4

.php_cs.dist

@@ -78,6 +78,13 @@ return PhpCsFixer\Config::create()
         'phpdoc_trim_consecutive_blank_line_separation' => true,
         'strict_comparison' => true,
         'strict_param' => true,
+        'visibility_required' => [
+            'elements' => [
+                'const',
+                'method',
+                'property',
+            ],
+        ],
         'void_return' => false, // BC breaks; to be done in API Platform 3.0
     ])
     ->setFinder($finder)

.travis.yml

@@ -11,7 +11,7 @@ jobs:
       env: NO_UNIT_TESTS=true
       before_install:
         - composer remove --dev ext-mongodb doctrine/mongodb-odm doctrine/mongodb-odm-bundle
-        - sed -i '26,32d' tests/Fixtures/app/config/config_common.yml
+        - sed -i '33,39d' tests/Fixtures/app/config/config_common.yml
     - php: '7.2'
     - php: '7.3'
     - php: '7.3'

CHANGELOG.md

@@ -1,5 +1,84 @@
 # Changelog
 
+## 2.5.0 beta 1
+
+* GraphQL: Add support for custom types
+
+## 2.4.0
+
+* Listeners are now opt-in when not handling API Platform operations
+* `DISTINCT` is not used when there are no joins
+* Preserve manual join in FilterEagerLoadingExtension
+* The `elasticsearch` attribute can be disabled resource-wise or per-operation
+* The `messenger` attribute can now take the `input` string as a value (`messenger="input"`). This will use a default transformer so that the given `input` is directly sent to the messenger handler.
+* The `messenger` attribute can be declared per-operation
+* Mercure updates are now published after the Doctrine flush event instead of on `kernel.terminate`, so the Mercure and the Messenger integration can be used together
+* Use Symfony's MetadataAwareNameConverter when available
+* Change the extension's priorities (`<0`) for improved compatibility with Symfony's autoconfiguration feature. If you have custom extensions we recommend to use positive priorities.
+
+| Service name                                               | Priority | Class                                              |
+|------------------------------------------------------------|------|---------------------------------------------------------|
+| api_platform.doctrine.orm.query_extension.eager_loading (collection) | -8 | ApiPlatform\Core\Bridge\Doctrine\Orm\Extension\EagerLoadingExtension |
+| api_platform.doctrine.orm.query_extension.eager_loading (item) | -8 | ApiPlatform\Core\Bridge\Doctrine\Orm\Extension\EagerLoadingExtension |
+| api_platform.doctrine.orm.query_extension.filter | -16 | ApiPlatform\Core\Bridge\Doctrine\Orm\Extension\FilterExtension |
+| api_platform.doctrine.orm.query_extension.filter_eager_loading | -17 | ApiPlatform\Core\Bridge\Doctrine\Orm\Extension\FilterEagerLoadingExtension |
+| api_platform.doctrine.orm.query_extension.order | -32 | ApiPlatform\Core\Bridge\Doctrine\Orm\Extension\OrderExtension |
+| api_platform.doctrine.orm.query_extension.pagination | -64 | ApiPlatform\Core\Bridge\Doctrine\Orm\Extension\PaginationExtension |
+
+* Fix JSON-LD contexts when using output classes
+* GraphQl: Fix pagination (the `endCursor` behavior was wrong)
+* GraphQl: Improve output/input behavior
+* GraphQl: Improve mutations (make the `clientMutationId` nullable and return mutation payload as an object)
+* MongoDB: Fix search filter when searching by related collection id
+* MongoDB: Fix numeric and range filters
+
+## 2.4.0 beta 2
+
+* Fix version constraints for Doctrine MongoDB ODM
+* Respect `_api_respond` request attribute in the SerializeListener
+* Change the normalizer's priorities (`< 0`). If you have custom normalizer we recommend to use positive priorities.
+
+| Service name                                               | Priority | Class                                              |
+|------------------------------------------------------------|------|---------------------------------------------------------|
+| api_platform.hydra.normalizer.constraint_violation_list   | -780 | ApiPlatform\Core\Hydra\Serializer\ConstraintViolationListNormalizer
+| api_platform.jsonapi.normalizer.constraint_violation_list | -780 | ApiPlatform\Core\JsonApi\Serializer\ConstraintViolationListNormalizer
+| api_platform.problem.normalizer.constraint_violation_list | -780 | ApiPlatform\Core\Problem\Serializer\ConstraintViolationListNormalizer
+| api_platform.swagger.normalizer.api_gateway               | -780 | ApiPlatform\Core\Swagger\Serializer\ApiGatewayNormalizer
+| api_platform.hal.normalizer.collection                    | -790 | ApiPlatform\Core\Hal\Serializer\CollectionNormalizer
+| api_platform.hydra.normalizer.collection_filters          | -790 | ApiPlatform\Core\Hydra\Serializer\CollectionFiltersNormalizer
+| api_platform.jsonapi.normalizer.collection                | -790 | ApiPlatform\Core\JsonApi\Serializer\CollectionNormalizer
+| api_platform.jsonapi.normalizer.error                     | -790 | ApiPlatform\Core\JsonApi\Serializer\ErrorNormalizer
+| api_platform.hal.normalizer.entrypoint                    | -800 | ApiPlatform\Core\Hal\Serializer\EntrypointNormalizer
+| api_platform.hydra.normalizer.documentation               | -800 | ApiPlatform\Core\Hydra\Serializer\DocumentationNormalizer
+| api_platform.hydra.normalizer.entrypoint                  | -800 | ApiPlatform\Core\Hydra\Serializer\EntrypointNormalizer
+| api_platform.hydra.normalizer.error                       | -800 | ApiPlatform\Core\Hydra\Serializer\ErrorNormalizer
+| api_platform.jsonapi.normalizer.entrypoint                | -800 | ApiPlatform\Core\JsonApi\Serializer\EntrypointNormalizer
+| api_platform.problem.normalizer.error                     | -810 | ApiPlatform\Core\Problem\Serializer\ErrorNormalizer
+| serializer.normalizer.json_serializable                   | -900 | Symfony\Component\Serializer\Normalizer\JsonSerializableNormalizer
+| serializer.normalizer.datetime                            | -910 | Symfony\Component\Serializer\Normalizer\DateTimeNormalizer
+| serializer.normalizer.constraint_violation_list           | -915 | Symfony\Component\Serializer\Normalizer\ConstraintViolationListNormalizer
+| serializer.normalizer.dateinterval                        | -915 | Symfony\Component\Serializer\Normalizer\DateIntervalNormalizer
+| serializer.normalizer.data_uri                            | -920 | Symfony\Component\Serializer\Normalizer\DataUriNormalizer
+| api_platform.graphql.normalizer.item                      | -922 | ApiPlatform\Core\GraphQl\Serializer\ItemNormalizer
+| api_platform.hal.normalizer.item                          | -922 | ApiPlatform\Core\Hal\Serializer\ItemNormalizer
+| api_platform.jsonapi.normalizer.item                      | -922 | ApiPlatform\Core\JsonApi\Serializer\ItemNormalizer
+| api_platform.jsonld.normalizer.item                       | -922 | ApiPlatform\Core\JsonLd\Serializer\ItemNormalizer
+| api_platform.serializer.normalizer.item                   | -923 | ApiPlatform\Core\Serializer\ItemNormalizer
+| serializer.normalizer.object                              | -1000 | Symfony\Component\Serializer\Normalizer\ObjectNormalizer
+
+* Allow custom stylesheets to be appended or replaced in the swagger UI
+* Load messenger only if available
+* Fix missing metadata cache pool for Elasticsearch
+* Make use of the new AdvancedNameConverterInterface interface for name converters
+* Refactor input/output attributes, where these attributes now take:
+  - an array specifying a class and some specific attributes (`name` and `iri` if needed)
+  - a string representing the class
+  - a `falsy` boolean to disable the input/output
+* Introduce the DataTransformer concept to transform an input/output from/to a resource
+* Api Platform normalizer is not limited to Resources anymore (you can use DTO as relations and more...)
+* MongoDB: allow a `0` limit in the pagination
+* Fix support of a discriminator mapping in an entity
+
 ## 2.4.0 beta 1
 
 * MongoDB: full support
@@ -17,7 +96,7 @@
 * Allow to set the HTTP status code to send to the client through the `status` attribute
 * Add support for the `Sunset` HTTP header using the `sunset` attribute
 * Set the `Content-Location` and `Location` headers when appropriate for better RFC7231 conformance
-* Display the matching data provider and data persiter in the debug panel
+* Display the matching data provider and data persister in the debug panel
 * GraphQL: improve performance by lazy loading types
 * Add the `api_persist` request attribute to enable or disable the `WriteListener`
 * Allow to set a default context in all normalizers
@@ -35,7 +114,7 @@
 
 ## 2.3.6
 
-* /!\ Security: a vulnerability impacting the GraphQL subsystem was allowing users authorized to run mutations for a specific resource type, to execute it on any resource, of any type
+* /!\ Security: a vulnerability impacting the GraphQL subsystem was allowing users authorized to run mutations for a specific resource type, to execute it on any resource, of any type (CVE-2019-1000011)
 * Fix normalization of raw collections (not API resources)
 * Fix content negotiation format matching
 
@@ -120,7 +199,7 @@
 
 ## 2.2.10
 
-* /!\ Security: a vulnerability impacting the GraphQL subsystem was allowing users authorized to run mutations for a specific resource type, to execute it on any resource, of any type
+* /!\ Security: a vulnerability impacting the GraphQL subsystem was allowing users authorized to run mutations for a specific resource type, to execute it on any resource, of any type (CVE-2019-1000011)
 
 ## 2.2.9
 
@@ -203,7 +282,7 @@
 
 ## 2.2.2
 
-* Autoregister classes implementing `SubresourceDataProviderInterface` 
+* Autoregister classes implementing `SubresourceDataProviderInterface`
 * Fix the `DateTimeImmutable` support in the date filter
 * Fix a BC break in `DocumentationAction` impacting NelmioApiDoc
 * Fix the context passed to data providers (improve the eager loading)
@@ -233,9 +312,9 @@
 * Remove the `api_platform.doctrine.listener.view.write` event listener service.
 * Add a data persistence layer with a new `ApiPlatform\Core\DataPersister\DataPersisterInterface` interface.
 * Add the a new configuration to disable the API entrypoint and the documentation
-* Allow to set maximum items per page at operation/resource level  
+* Allow to set maximum items per page at operation/resource level
 * Add the ability to customize the message when configuring an access control rule trough the `access_control_message` attribute
-* Allow empty operations in XML configs 
+* Allow empty operations in XML configs
 
 ## 2.1.6
 
@@ -262,14 +341,14 @@
 ## 2.1.4
 
 * Symfony 3.4 and 4.0 compatibility
-* Autowiring strict mode compatibility 
+* Autowiring strict mode compatibility
 * Fix a bug preventing to create resource classes in the global namespace
 * Fix Doctrine type conversion in filter's WHERE clauses
 * Fix filters when using eager loading and non-association composite identifier
-* Fix Doctrine type resolution for identifiers (for custom DBALType) 
+* Fix Doctrine type resolution for identifiers (for custom DBALType)
 * Add missing Symfony Routing options to operations configuration
 * Add SubresourceOperations to metadata
-* Fix disabling of cache pools with the dev environment 
+* Fix disabling of cache pools with the dev environment
 
 ## 2.1.3
 

appveyor.yml

@@ -34,4 +34,5 @@ services:
 test_script:
   - cd %APPVEYOR_BUILD_FOLDER%
   - php vendor\behat\behat\bin\behat --format=progress --suite=default
+  - rmdir tests\Fixtures\app\var\cache /s /q
   - php vendor\phpunit\phpunit\phpunit

behat.yml.dist

@@ -2,6 +2,7 @@ default:
   suites:
     default:
       contexts:
+        - 'CommandContext'
         - 'DoctrineContext':
             doctrine: '@doctrine'
         - 'HttpHeaderContext'
@@ -18,9 +19,10 @@ default:
         - 'Behat\MinkExtension\Context\MinkContext'
         - 'Behatch\Context\RestContext'
       filters:
-        tags: '~@postgres&&~@elasticsearch'
+        tags: '~@postgres&&~@mongodb&&~@elasticsearch'
     postgres:
       contexts:
+        - 'CommandContext'
         - 'DoctrineContext':
             doctrine: '@doctrine'
         - 'HttpHeaderContext'
@@ -37,9 +39,10 @@ default:
         - 'Behat\MinkExtension\Context\MinkContext'
         - 'Behatch\Context\RestContext'
       filters:
-        tags: '~@sqlite&&~@elasticsearch'
+        tags: '~@sqlite&&~@mongodb&&~@elasticsearch'
     mongodb:
       contexts:
+        - 'CommandContext'
         - 'DoctrineContext':
             doctrine: '@doctrine_mongodb'
         - 'HttpHeaderContext'
@@ -89,6 +92,7 @@ coverage:
   suites:
     default:
       contexts:
+        - 'CommandContext'
         - 'DoctrineContext':
             doctrine: '@doctrine'
         - 'HttpHeaderContext'
@@ -106,4 +110,4 @@ coverage:
         - 'Behat\MinkExtension\Context\MinkContext'
         - 'Behatch\Context\RestContext'
       filters:
-        tags: '~@postgres&&~@elasticsearch'
+        tags: '~@postgres&&~@mongodb&&~@elasticsearch'

composer.json

@@ -39,25 +39,33 @@
         "doctrine/mongodb-odm-bundle": "^4.0.0@beta",
         "doctrine/orm": "^2.6.3",
         "elasticsearch/elasticsearch": "^6.0",
-        "friendsofsymfony/user-bundle": "dev-fix-mongodb-mapping",
+        "friendsofsymfony/user-bundle": "^2.2@dev",
         "guzzlehttp/guzzle": "^6.0",
+        "jangregor/phpstan-prophecy": "^0.3",
         "justinrainbow/json-schema": "^5.0",
         "nelmio/api-doc-bundle": "^2.13.3",
         "php-mock/php-mock-phpunit": "^2.0",
         "phpdocumentor/reflection-docblock": "^3.0 || ^4.0",
         "phpdocumentor/type-resolver": "^0.3 || ^0.4",
         "phpspec/prophecy": "^1.8",
+        "phpstan/phpstan": "^0.11.3",
+        "phpstan/phpstan-doctrine": "^0.11.2",
+        "phpstan/phpstan-phpunit": "^0.11",
+        "phpstan/phpstan-symfony": "^0.11.2",
         "phpunit/phpunit": "^7.5.2",
         "psr/log": "^1.0",
         "ramsey/uuid": "^3.7",
         "ramsey/uuid-doctrine": "^1.4",
+        "sebastian/object-enumerator": "^3.0.3",
         "symfony/asset": "^3.4 || ^4.0",
         "symfony/cache": "^3.4 || ^4.0",
         "symfony/config": "^3.4 || ^4.0",
         "symfony/console": "^3.4 || ^4.0",
+        "symfony/css-selector": "^3.4 || ^4.0",
         "symfony/debug": "^3.4 || ^4.0",
         "symfony/dependency-injection": "^3.4 || ^4.0",
         "symfony/doctrine-bridge": "^3.4 || ^4.0",
+        "symfony/dom-crawler": "^3.4 || ^4.0",
         "symfony/event-dispatcher": "^3.4 || ^4.0",
         "symfony/expression-language": "^3.4 || ^4.0",
         "symfony/finder": "^3.4 || ^4.0",
@@ -71,15 +79,16 @@
         "symfony/security-bundle": "^3.4 || ^4.0",
         "symfony/twig-bundle": "^3.4 || ^4.0",
         "symfony/validator": "^3.4 || ^4.0",
-        "symfony/web-profiler-bundle": "^3.4 || ^4.0",
+        "symfony/web-profiler-bundle": "^4.2",
         "symfony/yaml": "^3.4 || ^4.0",
         "webonyx/graphql-php": ">=0.13 <1.0"
     },
     "conflict": {
-        "doctrine/common": "<2.7"
+        "doctrine/common": "<2.7",
+        "doctrine/mongodb-odm": "<2.0"
     },
     "suggest": {
-        "doctrine/mongodb-odm-bundle": "To support MongoDB.",
+        "doctrine/mongodb-odm-bundle": "To support MongoDB. Only versions 4.0 and later are supported.",
         "elasticsearch/elasticsearch": "To support Elasticsearch.",
         "friendsofsymfony/user-bundle": "To use the FOSUserBundle bridge.",
         "guzzlehttp/guzzle": "To use the HTTP cache invalidation system.",
@@ -107,12 +116,5 @@
     },
     "config": {
         "sort-packages": true
-    },
-    "repositories": [
-        {
-            "type": "vcs",
-            "url": "https://github.com/alanpoulain/FOSUserBundle",
-            "no-api": true
-        }
-    ]
+    }
 }