Skip to content

Conversation

@sideeffffect
Copy link

No description provided.

@sideeffffect sideeffffect mentioned this pull request May 11, 2024
@sideeffffect
Copy link
Author

@cquiroz 🙏 ☝️

tags: [v*]

env:
PGP_PASSPHRASE: ${{ secrets.PGP_PASSPHRASE }}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These need to be included to do publication I think

- name: Publish
run: sbt '++ ${{ matrix.scala }}' tlRelease
env:
SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see they are defined here

addSbtPlugin("io.github.cquiroz" % "sbt-tzdb" % "4.2.0")

addSbtPlugin("org.typelevel" % "sbt-typelevel" % "0.4.17")
addSbtPlugin("org.typelevel" % "sbt-typelevel-ci-release" % "0.7.1")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks

sbt
@@ -0,0 +1,664 @@
#!/usr/bin/env bash
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you include the sbt script?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The macOS image doesn't seem to contain sbt. So we include this bash wrapper script which make sbt startable from anywhere (anywhere bash is).

@cquiroz
Copy link
Owner

cquiroz commented May 17, 2024

Thanks this is great, do you kow why one of the build steps doesn't complete?

@cquiroz cquiroz closed this May 19, 2024
@cquiroz cquiroz reopened this May 19, 2024
@cquiroz cquiroz merged commit db787b1 into cquiroz:master May 19, 2024
@sideeffffect sideeffffect deleted the update-versions branch May 19, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants