Setup sbt-typelevel #418
Setup sbt-typelevel #418
Conversation
|
|
||
| val scalaVer = versions("2.13") | ||
| val scala3Ver = versions("3") | ||
| val tzdbVersion = "2019c" |
There was a problem hiding this comment.
Perhaps we should do 2022b or newer to exercise the parser fix
There was a problem hiding this comment.
Agree. Follow-up PR? I also want to do a follow-up PR that fixes the tests, because right now it is not testing against the JDK at all. It will be a bit of work to fix all of that.
| javaOptions ++= Seq("-Dfile.encoding=UTF8"), | ||
| autoAPIMappings := true, | ||
| Compile / doc / sources := { if (isDotty.value) Seq() else (Compile / doc / sources).value } | ||
| Compile / doc / sources := Seq() |
There was a problem hiding this comment.
What is their purpose? The official documentation is the JDK Javadoc.
| zonesFilter := zonesFilterFn, | ||
| dbVersion := TzdbPlugin.Version(tzdbVersion), | ||
| tlFatalWarnings := false, | ||
| Test / test := (Compile / run).toTask("").value |
There was a problem hiding this comment.
I'll add a comment. When you call test it invokes run. This is so we don't have to add a separate step to CI for checking that.
| * If the field is {@link ChronoField#DAY_OF_WEEK DAY_OF_WEEK} then the | ||
| * range of the day-of-week, from 1 to 7, will be returned. | ||
| * All other {@code ChronoField} instances will throw a {@code DateTimeException}. | ||
| * If the field is {@link ChronoField#DAY_OF_WEEK DAY_OF_WEEK} then the range of the day-of-week, |
There was a problem hiding this comment.
Yes. Formatting was not being checked for Scala 3 until this PR.
|
Hi, thanks for this |
|
Right, but that PR will have to merge first since this one enforces that all code is formatted. |
|
I'm goingo to merge this including the formatting changes to get the ball rolling |
2 participants
No description provided.