Reiwa

[cquiroz]

Add support for Japanese Reiwa era, see ThreeTen#124
Note we need to run this PR on jdk 13
Includes #172

[SethTisue]

after this I'm getting:

[scala-java-time] [info] TestDateTimeTextPrinting:
[scala-java-time] [info] - appendText2arg_print
[scala-java-time] [info] - appendText1arg_print
[scala-java-time] [info] - print_appendText2arg_french_long
[scala-java-time] [info] - print_appendText2arg_french_short
[scala-java-time] [info] - appendTextMap
[scala-java-time] [info] - appendTextMap_DOM
[scala-java-time] [info] - appendTextMapIncomplete
[scala-java-time] [info] - formatFullDate
[scala-java-time] [info] - formatDayOfWeek *** FAILED ***
[scala-java-time] [info]   Expected "Tuesday Jan[.] 30", but got "Tuesday Jan[] 30" (TestDateTimeTextPrinting.scala:187)
[scala-java-time] [info] - formatTime_AM_PM *** FAILED ***
[scala-java-time] [info]   Expected "11:02 [a.m.]", but got "11:02 [AM]" (TestDateTimeTextPrinting.scala:194)

[scala-java-time] [error] Failed tests:
[scala-java-time] [error] 	org.threeten.bp.format.TestDateTimeTextPrinting

caught by Scala community build

[SethTisue]

oh, sorry, I guess it's actually expected that it fails on JDK 8?

would maybe be a bit nicer if the test were conditionalized on that

[cquiroz]

Indeed, I updated to jdk13
I’m more than happy to make the test conditional but it’d need to check the jvm version at compile time. I’m not sure if sbt can do that

[SethTisue]

as you wish, for yourself and your own contributors (I can exclude the test in the community build, so it's not really a problem for me)

[SethTisue]

it’d need to check the jvm version at compile time. I’m not sure if sbt can do that

why isn't it sufficient to check the JVM version at runtime?

[cquiroz]

This PR uses a constant Reiwa added in recent versions of the jvm, attempts to run on jvm 8 will fail to compile