Size reduction improvements #158
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Quiroz <carlos.m.quiroz@gmail.com>
Signed-off-by: Carlos Quiroz <carlos.m.quiroz@gmail.com>
|
So this gives a little improvement on size but I'm a bit hesitant to change the |
exoego
reviewed
Mar 7, 2020
| field.range | ||
| else if (field.isInstanceOf[ChronoField]) | ||
| throw new UnsupportedTemporalTypeException(s"Unsupported field: $field") | ||
| throw throw UnsupportedTemporalTypeException.field(field) |
|
I'm going to close this. The size gains are very small and imply API changes, probably not worth it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more size reductions. This gives me about 2.5% less final size on my demo