Use passed in executionDateTime timeZoneOffset when available#313
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #313 +/- ##
=======================================
Coverage 86.15% 86.15%
=======================================
Files 52 52
Lines 4506 4508 +2
Branches 1270 1270
=======================================
+ Hits 3882 3884 +2
Misses 324 324
Partials 300 300
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cmoesel
left a comment
There was a problem hiding this comment.
Thanks for this PR, @elsaperelli. It looks really good! I only made a couple of very minor comments -- none of which affect the actual code (just code comments and a test description).
cmoesel
left a comment
There was a problem hiding this comment.
This looks good! Thanks for making the engine better!
Pull requests into cql-execution require the following.
Submitter and reviewer should ✔ when done.
For items that are not-applicable, mark "N/A" and ✔.
CDS Connect and Bonnie are the main users of this repository.
It is strongly recommended to include a person from each of those projects as a reviewer.
Summary
Previously,
getDateTime()indateTime.tswas not passing in atimeZoneOffsetwhen creating a newDateTime. We only want to do this if anexecutionDateTimeis not provided since it will set thetimeZoneOffsetto thetimeZoneOffsetof the evaluation. In the case where theexecutionDateTimeis passed in, we want thetimeZoneOffsetto come from that. We now achieve this by passing thectx.getExecutionDateTime().timeZoneOffsetto functions that callgetDateTime().Submitter:
npm run test:plusto run tests, lint, and prettier)cql4browsers.jsbuilt withnpm run build:browserifyif source changed.Reviewer:
Name: