-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor "Engines" class #559
Conversation
JPercival
commented
Oct 13, 2024
- Rename overloads and reorder parameters so that they are consistent across each
- Refactor NPM logic so that it's consolidated in one place
- Refactor LibrarySourceProvider creation so that it's (mostly) in one place
- Fix duplicate FHIRLibrarySourceProvider bug
Formatting check succeeded! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #559 +/- ##
============================================
+ Coverage 73.20% 73.27% +0.07%
Complexity 19 19
============================================
Files 362 362
Lines 19287 19282 -5
Branches 2945 2944 -1
============================================
+ Hits 14119 14129 +10
+ Misses 3745 3731 -14
+ Partials 1423 1422 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somewhat unrelated note on the change in R4LibraryEvaluationService. I recently created a LibraryProcessor to handle the $package and $data-requirements operations for Library and also added an EvaluationProcessor for the $evaluate operation. I suggest we deprecate this class in favor of the new since this one is R4 only and the new class supports any version we have support for, as well as support for the prefetch parameter.
6f1c27f
to
12f0ea2
Compare
… consistenly named and ordered
b3457c6
to
11af6a8
Compare
Quality Gate passedIssues Measures |