Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor "Engines" class #559

Merged
merged 6 commits into from
Oct 16, 2024
Merged

Refactor "Engines" class #559

merged 6 commits into from
Oct 16, 2024

Conversation

JPercival
Copy link
Contributor

  • Rename overloads and reorder parameters so that they are consistent across each
  • Refactor NPM logic so that it's consolidated in one place
  • Refactor LibrarySourceProvider creation so that it's (mostly) in one place
  • Fix duplicate FHIRLibrarySourceProvider bug

Copy link

github-actions bot commented Oct 13, 2024

Formatting check succeeded!

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 94.54545% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.27%. Comparing base (057dac7) to head (77904a9).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...rc/main/java/org/opencds/cqf/fhir/cql/Engines.java 93.61% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #559      +/-   ##
============================================
+ Coverage     73.20%   73.27%   +0.07%     
  Complexity       19       19              
============================================
  Files           362      362              
  Lines         19287    19282       -5     
  Branches       2945     2944       -1     
============================================
+ Hits          14119    14129      +10     
+ Misses         3745     3731      -14     
+ Partials       1423     1422       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@barhodes barhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhat unrelated note on the change in R4LibraryEvaluationService. I recently created a LibraryProcessor to handle the $package and $data-requirements operations for Library and also added an EvaluationProcessor for the $evaluate operation. I suggest we deprecate this class in favor of the new since this one is R4 only and the new class supports any version we have support for, as well as support for the prefetch parameter.

Base automatically changed from feature-settings-cleanup to master October 15, 2024 16:28
@JPercival JPercival force-pushed the feature-engines-cleanup branch 2 times, most recently from 6f1c27f to 12f0ea2 Compare October 15, 2024 21:18
Copy link

sonarcloud bot commented Oct 16, 2024

@JPercival JPercival merged commit 921ea25 into master Oct 16, 2024
8 checks passed
@JPercival JPercival deleted the feature-engines-cleanup branch October 16, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants