357

[dgarus]

Issue #357

We cannot remove the 'since' tag because it is mandatory for the current check style policy.

Additionally, I've created the issue in qulice.
That is why I didn't remove the JavadocTagsCheck tag from Base.java and DefaultBase.java.

[codecov-io]

Codecov Report

Merging #376 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #376   +/-   ##
=========================================
  Coverage     77.98%   77.98%           
  Complexity      204      204           
=========================================
  Files            36       36           
  Lines          1190     1190           
  Branches         88       88           
=========================================
  Hits            928      928           
  Misses          232      232           
  Partials         30       30

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae1caa2...3223d51. Read the comment docs.

[0crat]

This pull request #376 is assigned to @fabriciofx/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

[paulodamaso]

@0crat assign @fanifieiev

[fanifieiev]

@dgarus Please update the description section with the issue link this PR is fixing/resolving.
I need to understand the context and intention of this PR.
Thanks

[dgarus]

@fanifieiev Done.

[0crat]

@0crat assign @fanifieiev (here)

@paulodamaso @paulodamaso/z not enough funds available in the project, can't set budget of job #376, see §21; @fanifieiev/z will get no money on completion; in order to fix that, add funds to the project and assign the job again

[0crat]

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @paulodamaso/z

[fanifieiev]

@dgarus Please fix the merge conflict issue and have a look at the comment.
After you fix them, we should be good to merge this PR.

[dgarus]

@fanifieiev Done.
Thanks!

[fanifieiev]

@paulodamaso We are good to merge.

[0crat]

@fanifieiev/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

[paulodamaso]

@rultor merge

[rultor]

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@paulodamaso Done! FYI, the full log is here (took me 20min)

[0crat]

Job #376 is not in the agenda of @fanifieiev/z, can't retrieve data and time of add

[0crat]

Job #376 is not in the agenda of @fanifieiev/z, can't inspect

[0crat]

@sereshqua/z please review this job completed by @fanifieiev/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

[0crat]

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @paulodamaso/z

[sereshqua]

@fanifieiev please make sure you will find at least 3 issues during next CR, thanks :)

[sereshqua]

@fanifieiev ping

[sereshqua]

@0crat quality acceptable

[fanifieiev]

@sereshqua ok, got it

[0crat]

Order was finished, quality is "acceptable": +15 point(s) just awarded to @fanifieiev/z

[0crat]

Quality review completed: +4 point(s) just awarded to @sereshqua/z