Skip to content

Commit

Permalink
refactor: notes as data source
Browse files Browse the repository at this point in the history
  • Loading branch information
cpvalente committed Oct 19, 2024
1 parent dd4a165 commit b577057
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,12 @@ import { ViewOption } from '../../../common/components/view-params-editor/types'
export const getLowerThirdOptions = (customFields: CustomFields): ViewOption[] => {
const topSourceOptions = makeOptionsFromCustomFields(customFields, {
title: 'Title',
note: 'Note',
});

const bottomSourceOptions = makeOptionsFromCustomFields(customFields, {
title: 'Title',
note: 'Note',
none: 'None',
});

Expand Down
2 changes: 1 addition & 1 deletion apps/client/src/features/viewers/public/public.options.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { getTimeOption, makeOptionsFromCustomFields } from '../../../common/comp
import { ViewOption } from '../../../common/components/view-params-editor/types';

export const getPublicOptions = (timeFormat: string, customFields: CustomFields): ViewOption[] => {
const secondaryOptions = makeOptionsFromCustomFields(customFields);
const secondaryOptions = makeOptionsFromCustomFields(customFields, { note: 'Note' });

return [
{ section: 'Clock Options' },
Expand Down
5 changes: 3 additions & 2 deletions apps/client/src/features/viewers/timer/timer.options.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@ import {
import { ViewOption } from '../../../common/components/view-params-editor/types';

export const getTimerOptions = (timeFormat: string, customFields: CustomFields): ViewOption[] => {
const mainOptions = makeOptionsFromCustomFields(customFields, { title: 'Title' });
const secondaryOptions = makeOptionsFromCustomFields(customFields, { note: 'Note' });
const mainOptions = makeOptionsFromCustomFields(customFields, { title: 'Title', note: 'Note' });
const secondaryOptions = makeOptionsFromCustomFields(customFields, { title: 'Title', note: 'Note' });

return [
{ section: 'Clock Options' },
getTimeOption(timeFormat),
Expand Down

0 comments on commit b577057

Please sign in to comment.