Skip to content

Commit

Permalink
Revert "Disable flaky PerformanceManagerTabHelperTest.PageIsAudible"
Browse files Browse the repository at this point in the history
This reverts commit fe93195.

Reason for revert: This is a spurious failure caused by an
unrelated issue https://crbug.com/1012445. Individual test
should not be disabled because of this (a lot of tests are
affected -- it wouldn't make sense to disable all these 
tests because of a single problem).

Original change's description:
> Disable flaky PerformanceManagerTabHelperTest.PageIsAudible
> 
> TBR=fdoray
> 
> Bug: 1012601
> Change-Id: I9540e12715b4b431af0b886c280f609b51851b10
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852429
> Reviewed-by: David Roger <droger@chromium.org>
> Commit-Queue: David Roger <droger@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#704622}

TBR=droger@chromium.org,fdoray@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1012601
Change-Id: Icb00d26109eac1d532740b992acba94255c023a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872310
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707809}
  • Loading branch information
fdoray authored and Commit Bot committed Oct 21, 2019
1 parent 713600f commit ffe6dd7
Showing 1 changed file with 1 addition and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
#include "base/run_loop.h"
#include "base/stl_util.h"
#include "base/test/bind_test_util.h"
#include "build/build_config.h"
#include "components/performance_manager/graph/frame_node_impl.h"
#include "components/performance_manager/graph/graph_impl_operations.h"
#include "components/performance_manager/graph/page_node_impl.h"
Expand Down Expand Up @@ -219,13 +218,7 @@ void ExpectPageIsAudible(bool is_audible) {

} // namespace

// This test is flaky on windows. See https://1012601
#if defined(OS_WIN)
#define MAYBE_PageIsAudible DISABLED_PageIsAudible
#else
#define MAYBE_PageIsAudible PageIsAudible
#endif
TEST_F(PerformanceManagerTabHelperTest, MAYBE_PageIsAudible) {
TEST_F(PerformanceManagerTabHelperTest, PageIsAudible) {
SetContents(CreateTestWebContents());

ExpectPageIsAudible(false);
Expand Down

0 comments on commit ffe6dd7

Please sign in to comment.