use http constants instead of magic number

cpraehaus · Mar 16, 2022 · 93633fb · 93633fb
1 parent 2278312
commit 93633fb
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 9 deletions.
diff --git a/provider/kannel/kannel.go b/provider/kannel/kannel.go
@@ -31,7 +31,7 @@ func NewKannel(config Config) *Kannel {
 }
 
 // Send send sms to n number of people using bulk sms api.
-func (c *Kannel) Send(message sachet.Message) (err error) {
+func (c *Kannel) Send(message sachet.Message) error {
 	for _, recipient := range message.To {
 		queryParams := url.Values{
 			"from": {message.From},
@@ -59,9 +59,10 @@ func (c *Kannel) Send(message sachet.Message) (err error) {
 			return err
 		}
 
-		if response.StatusCode >= 400 {
+		if response.StatusCode >= http.StatusBadRequest {
 			return fmt.Errorf("Failed sending sms. statusCode: %d", response.StatusCode)
 		}
 	}
-	return
+
+	return nil
 }
diff --git a/provider/otc/otc.go b/provider/otc/otc.go
@@ -115,7 +115,7 @@ func (c *OTC) loginRequest() error {
 	}
 	defer resp.Body.Close()
 
-	if resp.StatusCode >= 400 {
+	if resp.StatusCode >= http.StatusBadRequest {
 		return fmt.Errorf("OTC API request failed with HTTP status code %d", resp.StatusCode)
 	}
 
@@ -198,15 +198,15 @@ func (c *OTC) SendRequest(method, resource string, payload *smsRequest, attempts
 	}
 	defer resp.Body.Close()
 
-	if resp.StatusCode == 401 {
+	if resp.StatusCode == http.StatusUnauthorized {
 		// Set empty token to force login.
 		c.Token = ""
 		if attempts--; attempts > 0 {
 			return c.SendRequest(method, resource, payload, attempts)
 		} else {
 			return nil, err
 		}
-	} else if resp.StatusCode >= 400 {
+	} else if resp.StatusCode >= http.StatusBadRequest {
 		return nil, fmt.Errorf("OTC API request %s failed with HTTP status code %d", url, resp.StatusCode)
 	}
 

diff --git a/provider/smsc/smsc.go b/provider/smsc/smsc.go
@@ -36,10 +36,10 @@ func (c *Smsc) Send(message sachet.Message) (err error) {
 	return
 }
 
-func (c *Smsc) SendOne(message sachet.Message, PhoneNumber string) (err error) {
+func (c *Smsc) SendOne(message sachet.Message, phoneNumber string) (err error) {
 	encoded_message := url.QueryEscape(message.Text)
 	smsURL := fmt.Sprintf("https://smsc.ru/sys/send.php?login=%s&psw=%s&phones=%s&sender=%s&fmt=0&mes=%s",
-		c.Login, c.Password, PhoneNumber, message.From, encoded_message)
+		c.Login, c.Password, phoneNumber, message.From, encoded_message)
 	var request *http.Request
 	var resp *http.Response
 	request, err = http.NewRequest("GET", smsURL, nil)

diff --git a/provider/textmagic/textmagic.go b/provider/textmagic/textmagic.go
@@ -37,7 +37,7 @@ func NewTextMagic(config Config) *TextMagic {
 func (tm *TextMagic) Send(message sachet.Message) (err error) {
 	switch message.Type {
 	case "", "text":
-		joinedTo := strings.Join(message.To[:], ",")
+		joinedTo := strings.Join(message.To, ",")
 		_, _, err = tm.client.TextMagicApi.SendMessage(tm.auth, textmagic.SendMessageInputObject{
 			Text:   message.Text,
 			Phones: joinedTo,