You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Proposed fix for Issue#20
I'm not entirely sure what --premium=safety-off does as it is not mentioned in the manual, but unless order of the arguments is important somehow, this should fix open source versions and keep the same arguments in premium.
I'm not entirely sure what --premium=safety-off does
the reason cppcheclipse uses this is that if cppcheck is executed in "safety" mode (default in cppcheck premium) then it will return nonzero exitcode if there are critical errors and then cppcheclipse will fail. with this option cppcheclipse is able to output the error messages..
normally open source does not run in "safety" mode but it could if a cppcheck.cfg with that option is provided.
--no-safety could be an alternative it works both in premium and open source: https://github.com/danmar/cppcheck/blob/main/cli/cmdlineparser.cpp#L1019
however --no-safety was added last year and will not work on older versions. So well I guess your fix looks reasonable, however I am not an expert on cppcheclipse code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
danmar
changed the title
Proposed fix for Issue#20
I'm not entirely sure what
--premium=safety-offdoes as it is not mentioned in the manual, but unless order of the arguments is important somehow, this should fix open source versions and keep the same arguments in premium.