#12254: cppcheck.cfg can't be loaded from relative paths anymore - #5780
Open
olabetskyi wants to merge 14 commits into
Open
#12254: cppcheck.cfg can't be loaded from relative paths anymore#5780olabetskyi wants to merge 14 commits into
olabetskyi wants to merge 14 commits into
Conversation
danmar
reviewed
Dec 18, 2023
danmar
reviewed
Dec 18, 2023
danmar
reviewed
Dec 18, 2023
olabetskyi
force-pushed
the
ticket_12254
branch
from
December 19, 2023 14:21
811da83 to
eb116f9
Compare
olabetskyi
force-pushed
the
ticket_12254
branch
from
December 19, 2023 15:37
d7f5c61 to
ecfbb79
Compare
danmar
reviewed
Dec 20, 2023
danmar
left a comment
danmar
left a comment
Contributor
There was a problem hiding this comment.
looks good. I have some nits.
|
|
||
| args.insert(0, cppcheck_exe) | ||
|
|
||
| exitcode, _, stderr = cppcheck(args) |
Contributor
There was a problem hiding this comment.
stylistically I would personally tighten this:
exitcode, _, stderr = cppcheck([cppcheck_exe, '--premium=misra-c++-2008', test_file])
or at least just create args, with the exe filename as first option directly.
Contributor
There was a problem hiding this comment.
it would also be interesting to check that stdout does not complain about unhandled option.
danmar
reviewed
Dec 20, 2023
danmar
left a comment
danmar
left a comment
Contributor
There was a problem hiding this comment.
I just have minor nits. when those are done and CI is happy I think we can merge this.
| 'Checking {} ...'.format(test_file) | ||
| ] | ||
| lines = stdout.splitlines() | ||
| assert lines == out_lines |
Contributor
There was a problem hiding this comment.
well it works but I guess you could also just write:
assert f'Checking {test_file} ...' == stdout.strip()
|
|
||
| # check the version it should be as in cfg | ||
| exitcode, stdout, stderr = cppcheck([cppcheck_exe, '--version']) | ||
| assert stdout == product_name + '\n' |
Contributor
There was a problem hiding this comment.
maybe stdout.strip() == product_name would be somewhat better. So it doesn't care if there is "\r\n" in windows. or extra newlines.
danmar
reviewed
Dec 22, 2023
|
|
||
| # should be fine now | ||
| exitcode, stdout, stderr = cppcheck([cppcheck_exe, '--premium=misra-c++-2008', test_file]) | ||
| exitcode, stdout, stderr = cppcheck(['--premium=misra-c++-2008', test_file], None, True, cppcheck_exe) |
Contributor
There was a problem hiding this comment.
rather than providing all arguments explicitly it's better to write:
exitcode, stdout, stderr = cppcheck(['--premium=misra-c++-2008', test_file], cppcheck_exe=cppcheck_exe)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix python tests