Skip to content

Make eval api simpler #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2019
Merged

Make eval api simpler #29

merged 1 commit into from
Apr 18, 2019

Conversation

@theidexisted
Copy link

@theidexisted theidexisted commented Apr 9, 2019

The numkeys argument is redundant here, just remove it.

Maybe we need to add a api like this from jedis:

public Object eval(String script,
                   int keyCount,
                   String... params)
Specified by:
eval in interface ScriptingCommands

@appkins appkins merged commit c53f12d into cpp-redis:master Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@theidexisted @appkins