Add support for CLIENT SETNAME command to cpp_redis::Subscriber #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redis server supports 64 bit ints for TTL. Actually up to 0x7FFFFFFFFFFFFFFFLL milliseconds. Or 0x7FFFFFFFFFFFFFFFLL/1000 seconds.
… problem were the AUTH command got serialized twice to the buffer to be sent to the TCP connection by unprotected_auth: Once when it was directly added to the buffer AND Once because it was added to the command queue it got serialize to the buffer again However there was only one call back on the command queue. So we got 2 responces and only one callback to handle them. So the next command in the queue gets the second AUTH response instead of the expected responce and everything is off by one.
|
The CI build passed for Linux. I still need to update the OSX build this week, I'm going to merge the commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to send the CLIENT SETNAME command to label the subscriber client connection on the server side. This is useful for debugging and management from the server side of things, particularly when you have a large number of connections.
The CLIENT command must be sent after the AUTH (if used) and before the first SUBSCRIBE command is sent or the Redis server will issue an error. In order for this to work after a reconnect, the subscriber needs to manage the re-issuing of the CLIENT SETNAME command to be sure it is sent after re_auth and before the re_subscribe occurs.