Fix never-returning xreadgroup case in example #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default `XGROUP CREATE` passes `$` as the ID which means "serve all IDs added from this point on". Due to that, the `XADD` directly above never gets served to the `XREADGROUP` command and this example will just hang the first time you run it waiting. Adding an explicit ID of 0 means we will get the previous message back in the `XREADGROUP`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default
XGROUP CREATEpasses$as the ID which means "serve all IDs added from this point on".Due to that, the
XADDdirectly above never gets served to theXREADGROUPcommand and this example will just hang the first time you run it waiting.Adding an explicit ID of 0 means we will get the previous message back in the
XREADGROUP.