Skip to content

[REF] refactor the way the ROIs are saved #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2022
Merged

[REF] refactor the way the ROIs are saved #44

merged 2 commits into from
Jun 3, 2022

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Jun 3, 2022

closes #43

@Remi-Gau Remi-Gau linked an issue Jun 3, 2022 that may be closed by this pull request
1 task
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #44 (586a235) into dev (5ff89c8) will increase coverage by 0.05%.
The diff coverage is 94.11%.

❗ Current head 586a235 differs from pull request most recent head 68a541e. Consider uploading reports for the commit 68a541e to get more accurate results

@@            Coverage Diff             @@
##              dev      #44      +/-   ##
==========================================
+ Coverage   89.78%   89.84%   +0.05%     
==========================================
  Files          23       23              
  Lines         509      512       +3     
==========================================
+ Hits          457      460       +3     
  Misses         52       52              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/roi/plotDataInRoi.m 96.93% <93.75%> (+0.23%) ⬆️
src/roi/createRoi.m 92.10% <100.00%> (-0.27%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Remi-Gau Remi-Gau merged commit f1d29f5 into dev Jun 3, 2022
@Remi-Gau Remi-Gau deleted the simplify branch June 3, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify saving ROI as .nii in createRoi
1 participant