Skip to content

resliceToiImage - interpolation type suggestion #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 28, 2022

Conversation

CerenB
Copy link
Collaborator

@CerenB CerenB commented Oct 13, 2021

This is a suggestion of interpolation type change for reslicing images.
The suggestion was due to @mohmdrezk warning. I want to ask of this is what he meant + if someone else has an objection to it or not.

@CerenB CerenB requested review from Remi-Gau and mohmdrezk October 13, 2021 14:27
@CerenB
Copy link
Collaborator Author

CerenB commented Oct 13, 2021

I might be wrong but here is a bit more thought on it.
interpolation == 4 could work well for the zMap, but not for the atlases where the labelling of the voxels are e.g. [1, 2, 3, 4, ...]
interpolation == 1 would perform the following [1.2 1.3 1.4] values which would not be good for the atlas masks.
Looking forward to hearing your ideas/input.

@mohmdrezk
Copy link

If you are re-slicing a multi-label atlas to different resolution and you want to preserve the same labels, then the interpolation method that should be used is the nearest neighbor (interpolation == 1).

inserted back the value 4 for tmaps. For atlases, we need to use interp = 1
@CerenB
Copy link
Collaborator Author

CerenB commented Oct 15, 2021

ok, if I understood @mohmdrezk right, then we would need a if case here. Please correct me if I'm wrong.

interp = 4 % for neurosynth (having zscores), tmaps, already extracted ROI from an atlas (not carrying mutliple labels)

if multilabelAtlas or binaryMap is used
interp = 1

But I'm guessing in atlas masks, this repo does not do reslicing. I haven't figure it out why/how though. WIP.

Again correct me if I'm wrong/missing a step:

  • we take ROIs from an atlas (making 1 label), binarize it
  • we reslice it, then due to interpolation I need to binarize it again
  • then I need to make 4D.nii in subject space

@mohmdrezk
Copy link

mohmdrezk commented Oct 15, 2021 via email

Copy link
Contributor

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge but this just contains only typo fixes now.

@Remi-Gau Remi-Gau merged commit 55f6053 into cpp-lln-lab:dev Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants