[FIX] return all labels for HCPex atlas #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @Remi-Gau - I've reviewed your changes and they look great!
General suggestions:
- Verify that the change in header line handling does not inadvertently include metadata as data.
- Ensure that the updated test reflects the intended behavior and accurately tests the fix.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
| @@ -62,7 +62,7 @@ | |||
|
|
|||
| fid = fopen(roiLabelLUT); | |||
| pattern = '%f%s%s%f'; | |||
| C = textscan(fid, pattern, 'Headerlines', 1); | |||
There was a problem hiding this comment.
question (bug_risk): Changing the 'Headerlines' parameter from 1 to 0 in the textscan function call will result in the first line of the file being read as data rather than being skipped as a header. Ensure that this change is intentional and that the first line of the file does not contain column headers or other metadata that should not be treated as data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getLookUpTable.m#117