Skip to content

add code to create raw tsv and make a markdown table + add submodules #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 8, 2023

Conversation

marcobarilari
Copy link
Contributor

No description provided.

@pep8speaks
Copy link

pep8speaks commented Oct 20, 2023

Hello @marcobarilari! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1:80: E501 line too long (81 > 79 characters)

Line 29:80: E501 line too long (82 > 79 characters)
Line 138:80: E501 line too long (85 > 79 characters)
Line 149:80: E501 line too long (81 > 79 characters)
Line 172:80: E501 line too long (83 > 79 characters)
Line 174:80: E501 line too long (84 > 79 characters)
Line 177:80: E501 line too long (88 > 79 characters)
Line 190:80: E501 line too long (86 > 79 characters)

Comment last updated at 2023-11-08 09:11:57 UTC

@marcobarilari marcobarilari changed the title add code to create raw tsv and make a markdown table add code to create raw tsv and make a markdown table + add submodules Oct 21, 2023
@marcobarilari
Copy link
Contributor Author

@Remi-Gau will merge tomorrow morning (around 10:15) to have some basic stuff to show around. However, if you think you want to review this first one to start with the right step I am happy to leave it open for a little while more.

@@ -0,0 +1,25 @@
| name | nb_subjects | has_participant_tsv | has_participant_json | participant_columns | has_phenotype_dir | modalities | sessions | tasks | fmriprep | freesurfer | mriqc |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the moment I would drop the columns :

  • has_participant_tsv
  • has_participant_json
  • has_phenotype_dir
  • participant_columns

Copy link
Collaborator

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop some of the columns we do not care about

marcobarilari and others added 2 commits October 27, 2023 12:38
Co-authored-by: Remi Gau <remi_gau@hotmail.com>
@Remi-Gau
Copy link
Collaborator

you probably want to:

  • rerun the script
  • delete and gitignore the pycache folder

@Remi-Gau
Copy link
Collaborator

also if you want to jsut reformat your code to get less complaints like this one,
just run in the repo.

pip install black
black .

@Remi-Gau
Copy link
Collaborator

Remi-Gau commented Nov 8, 2023

will push a couple of changes and merge

add code to create raw tsv and make a markdown table + add submodules (Sourcery refactored)
@Remi-Gau Remi-Gau merged commit bd8d154 into main Nov 8, 2023
@Remi-Gau Remi-Gau deleted the marco_create-tsv branch November 8, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants