dockathon Marco pt. 2 #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

marcobarilari merged 12 commits into cpp-lln-lab:doc from marcobarilari:marco_dochaton-pt2

Nov 16, 2020

Collaborator

marcobarilari commented Nov 16, 2020

No description provided.

marcobarilari added 5 commits

November 16, 2020 16:49


          update doc checkCppBidsDependencies

697585d


          add doc to returnNamesExtraColumns

dfc3843


          add doc to returnHeaderName


          add doc to printCreditsCppBids

0a6222e


          add doc to isPositiveInteger

444b043

marcobarilari requested review from CerenB, Remi-Gau and anege

November 16, 2020 17:31

marcobarilari added the documentation label

CerenB reviewed

View reviewed changes

src/utils/printCreditsCppBids.m Outdated Show resolved Hide resolved

Remi-Gau requested changes

View reviewed changes

src/utils/checkCppBidsDependencies.m Outdated Show resolved Hide resolved

src/utils/isPositiveInteger.m Show resolved Hide resolved

src/utils/printCreditsCppBids.m Outdated Show resolved Hide resolved

src/utils/returnHeaderName.m Outdated Show resolved Hide resolved

CerenB reviewed

View reviewed changes

src/utils/printCreditsCppBids.m Show resolved Hide resolved

CerenB reviewed

View reviewed changes

src/utils/printCreditsCppBids.m Outdated Show resolved Hide resolved

CerenB reviewed

View reviewed changes

src/utils/returnHeaderName.m Outdated Show resolved Hide resolved

CerenB reviewed

View reviewed changes

src/utils/returnHeaderName.m Show resolved Hide resolved


          Update src/utils/checkCppBidsDependencies.m

71fc4e7

Co-authored-by: Remi Gau <remi_gau@hotmail.com>

marcobarilari commented

View reviewed changes

src/utils/isPositiveInteger.m Show resolved Hide resolved


          Update src/utils/printCreditsCppBids.m

e4d0b50

Co-authored-by: CerenB <battal.ceren@gmail.com>

CerenB reviewed

View reviewed changes

src/utils/returnNamesExtraColumns.m Outdated Show resolved Hide resolved

CerenB approved these changes

View reviewed changes

Collaborator

CerenB left a comment

minor suggestions/typo corrections

marcobarilari and others added 4 commits

November 16, 2020 18:49


          Update src/utils/printCreditsCppBids.m

f8fb13e

Co-authored-by: CerenB <battal.ceren@gmail.com>


          Update src/utils/returnHeaderName.m

13844c6

Co-authored-by: Remi Gau <remi_gau@hotmail.com>


          Update src/utils/returnHeaderName.m

be37036

Co-authored-by: CerenB <battal.ceren@gmail.com>


          Update src/utils/returnNamesExtraColumns.m

94e601c

Co-authored-by: CerenB <battal.ceren@gmail.com>

Collaborator Author

marcobarilari commented Nov 16, 2020

thanks for checking, so many typos 😅😅

marcobarilari commented

View reviewed changes

src/utils/returnHeaderName.m Outdated Show resolved Hide resolved


          Apply suggestions from code review

94d911d

marcobarilari marked this pull request as ready for review

November 16, 2020 18:04

Remi-Gau mentioned this pull request

make isPositiveInteger accept row OR column vector #134

Closed

Remi-Gau approved these changes

View reviewed changes

Contributor

Remi-Gau left a comment

Good to go !

marcobarilari merged commit cbb55a1 into cpp-lln-lab:doc

marcobarilari deleted the marco_dochaton-pt2 branch

November 16, 2020 18:57

CerenB approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels