Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change ${{ github.action_path }} with $GITHUB_ACTION_PATH #160

Merged
merged 1 commit into from
Sep 5, 2023
Merged

change ${{ github.action_path }} with $GITHUB_ACTION_PATH #160

merged 1 commit into from
Sep 5, 2023

Conversation

carlosala
Copy link
Contributor

@carlosala carlosala commented Sep 5, 2023

Hi! Super great action, kudos for all the work!

We noticed that, when using this action inside a custom container, ${{ github.action_path }} is not properly set up. Instead, $GITHUB_ACTION_PATH is set up as expected (it's already being used in this action, there should not be difference). Github seem to be tracking this issue actions/runner#2185 but they didn't merged the fix yet.
This change should not change the functionality for anyone.

Thanks @2bndy5 and all the team for the hard work!

Copy link
Collaborator

@2bndy5 2bndy5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first, I was worried about windows not recognizing the unix bash style syntax. But then I remembered that these cmds are all executed in bash.

@carlosala
Copy link
Contributor Author

That's it! Actually it's sh as far as I remember. But, yes! Always POSIX shells :)
Thanks!

@2bndy5 2bndy5 merged commit 3a896db into cpp-linter:main Sep 5, 2023
27 checks passed
@carlosala carlosala deleted the fix-custom-container branch September 5, 2023 21:57
@carlosala
Copy link
Contributor Author

Thanks for the fast merge :)
Could we get it tagged into the v2 version? Thanks!

@shenxianpeng
Copy link
Collaborator

The tests look good so I have tagged into the v2 version.

@shenxianpeng shenxianpeng added the bug Something isn't working label Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants