Update build.yml

[shenxianpeng]

Summary by CodeRabbit

• Chores
  • Improved macOS build process with enhanced compiler and linker flags for better optimization.
  • Updated build steps to dynamically patch relevant files for compatibility.
  • Clarified macOS runner architecture in documentation.
  • Refined release process by specifying tag and release name in draft releases.

[coderabbitai]

Walkthrough

The macOS build workflow was updated to enhance dead code stripping, restrict LLVM targets to X86, and dynamically patch all relevant CMake implicit link info files. The draft release job was also updated to explicitly set the tag and release name based on the commit SHA.

Changes

File(s)	Change Summary
.github/workflows/build.yml	Enhanced macOS build with dead code stripping flags, limited LLVM targets to X86, dynamically patched all CMakeParseImplicitLinkInfo.cmake files under Homebrew, clarified Intel runner, and updated draft release job with explicit tag and release name.

Possibly related PRs

• Update build-amd64.yml #37: Updates macOS build workflow, including patching CMake implicit link libraries and runner settings.
• update build.yml and add .gitignore #54: Modifies macOS build workflow with changes to compiler/linker flags, LLVM target settings, and dynamic CMake patching.
• update build pipeline to fix macos build #56: Adjusts macOS build configuration, compiler flags, and CMake implicit link info patching in the workflow.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

.github/workflows/build.yml (1)

137-145: Patch all CMake implicit link info files dynamically
Replacing the hard-coded path with a find … | sed loop ensures you cover all Homebrew CMake info files. Consider handling paths with whitespace more robustly, for example:

- FILES=$(find "$BREW_PREFIX" -name CMakeParseImplicitLinkInfo.cmake)
- for file in $FILES; do
+ find "$BREW_PREFIX" -name CMakeParseImplicitLinkInfo.cmake -print0 | \
+ while IFS= read -r -d '' file; do
     echo "Patching $file"
     sed -i.backup 's/gcc_eh.*|/gcc_eh.*|gcc_ext.*|/g' "$file"
   done

This avoids word-splitting issues on paths that contain whitespace.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 11dfa47 and e97f377.

📒 Files selected for processing (1)

• .github/workflows/build.yml (4 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (20)

• GitHub Check: build (8, windows)
• GitHub Check: build (9, windows)
• GitHub Check: build (12, windows)
• GitHub Check: build (12.0.1, windows)
• GitHub Check: build (12, linux)
• GitHub Check: build (13, windows)
• GitHub Check: build (14, windows)
• GitHub Check: build (15, windows)
• GitHub Check: build (15, linux)
• GitHub Check: build (17, windows)
• GitHub Check: build (16, windows)
• GitHub Check: build (20, windows)
• GitHub Check: build (19, windows)
• GitHub Check: build (16, linux)
• GitHub Check: build (18, macosx)
• GitHub Check: build (18, linux)
• GitHub Check: build (19, macosx)
• GitHub Check: build (19, linux)
• GitHub Check: build (20, macosx)
• GitHub Check: build (20, linux)

🔇 Additional comments (4)

.github/workflows/build.yml (4)

66-66: Enable dead code stripping and restrict targets to X86
Good addition of -ffunction-sections -fdata-sections and -Wl,-dead_strip flags to reduce binary size, and the -DLLVM_TARGETS_TO_BUILD=X86 to limit build scope.

---

203-203: Document Intel-based macOS runner
Marking macos-13 explicitly as Intel is helpful for future maintainers, especially as Apple transitions to ARM runners.

---

286-287: Set explicit tag and release name for draft releases
Injecting the short commit SHA into both tag and release_name ensures unique, reproducible draft releases.

---

290-290: Upload all built artifacts with globbing
The file_glob: true and file: clang-*/**/* combination will include every generated tool under the clang-* directories. Looks correct.