Skip to content

Fix #37 change version_tuple to string #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Fix #37 change version_tuple to string #38

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81d997f
Fix #37 change version_tuple to string
shenxianpeng Oct 13, 2022
b8edfaf
Update clang_tools/install.py
shenxianpeng Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clang_tools/install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def is_installed(tool_name: str, version: str) -> Optional[Path]:
ver_major = version_tuple[0]
if len(version_tuple) < 3:
# append minor and patch version numbers if not specified
version_tuple += (0,) * (3 - len(version_tuple))
version_tuple += ('0',) * (3 - len(version_tuple))
exe_name = (
f"{tool_name}" + (f"-{ver_major}" if install_os != "windows" else "") + suffix
)
Expand Down