fix: plugin test failure and change to GITHUB_TOKEN
#8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
shenxianpeng
force-pushed
the
fix-rate-limit-issue
branch
from
383642f to
715f612
Compare
shenxianpeng
changed the title
GITHUB_TOKEN
There was a problem hiding this comment.
Pull Request Overview
This PR updates the authentication token in the Bash utilities and refines the CI workflow to improve plugin test reliability.
- Switched from
GITHUB_API_TOKENtoGITHUB_TOKENinlib/utils.bash. - Added a manual dispatch trigger and expanded the
plugin_testmatrix in the GitHub Actions workflow. - Clarified step names, disabled fail-fast, and ensured the
GITHUB_TOKENis passed to test steps.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/utils.bash | Use GITHUB_TOKEN for Authorization header instead of GITHUB_API_TOKEN. |
| .github/workflows/build.yml | Added workflow_dispatch, expanded matrix versions, refined steps, and set GITHUB_TOKEN in env. |
Comments suppressed due to low confidence (1)
lib/utils.bash:39
- Update the preceding comment to reference
GITHUB_TOKENinstead ofGITHUB_API_TOKEN, and document this breaking change or provide a fallback for backward compatibility.
if [ -n "${GITHUB_TOKEN:-}" ]; then
|
|
||
| - name: Run ${{ matrix.tool.plugin }} version check | ||
| run: ${{ matrix.tool.command }} | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
[nitpick] Consider moving GITHUB_TOKEN into a job-level env: block under jobs.plugin_test so that it’s automatically available to all steps, reducing duplication.
Suggested change
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.