Skip to content

add specfic tag #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add specfic tag #11

wants to merge 4 commits into from

Conversation

shenxianpeng
Copy link
Contributor

No description provided.

@shenxianpeng shenxianpeng requested a review from Copilot June 11, 2025 22:02
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces the ability to fetch GitHub release assets for a specific tag rather than always using the latest release.

  • Adds a GH_REPO_TAG variable to pin the release tag.
  • Updates fetch_all_assets to call the /releases/tag/{tag} endpoint.
  • Adjusts the GH_REPO string (adds a trailing slash).
Comments suppressed due to low confidence (3)

lib/utils.bash:9

  • The trailing slash in GH_REPO may lead to double slashes in the API URL (.../clang-tools-static-binaries//releases). Consider removing the slash to keep the repository path consistent.
GH_REPO="cpp-linter/clang-tools-static-binaries/"

lib/utils.bash:52

  • When querying /releases/tag/{tag}, the response is a single object, not an array. Update the jq filter to .assets[] instead of .[0].assets[] so it correctly extracts the assets.
jq -r '.[0].assets[] | "\(.name) \(.browser_download_url)"'

lib/utils.bash:10

  • There are no tests covering the new tag-based asset fetch logic. Consider adding a unit or integration test to verify behavior when GH_REPO_TAG is set.
GH_REPO_TAG="master-b35c5633"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant