Add Hud. #22
Merged
Add Hud. #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swagween
approved these changes
Mar 15, 2024
| auto text = std::make_unique<ui::Text>(services); | ||
| m_score = text.get(); | ||
| text->text.set_height(TextHeight{60}); | ||
| text->text.set_string("9999999999"); |
There was a problem hiding this comment.
what is the purpose of this if you are just overwriting it on line 38?
There was a problem hiding this comment.
To get the maximum width the score could possibly take, and create the background with a slightly larger width.
| public: | ||
| explicit Hud(Services const& services); | ||
|
|
||
| void set_score(std::int64_t score); |
There was a problem hiding this comment.
what's the benefit of std::int64_t over, say uint64_t?
There was a problem hiding this comment.
Unsigned integers don't behave like numbers and should be avoided.
https://hamstergene.github.io/posts/2021-10-30-do-not-use-unsigned-for-nonnegativity/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Divide viewport into hud and game areas.
Add lavender hex for gun beam in styles.
Need to update bave to get a stable commit hash.
Close #5