Add iterator to pini #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karnkaul
requested changes
Jul 10, 2021
include/pini/pini.hpp
Outdated
| @@ -16,6 +17,13 @@ class pini { | |||
| bool load_file(std::filesystem::path const& filename); | |||
| bool load_text(std::string_view text); | |||
|
|
|||
| // iteration | |||
|
|
|||
| using const_iterator = std::unordered_map<std::string, std::string>::const_iterator; | |||
There was a problem hiding this comment.
Just curious: any reason you don't want to alias the map type itself, and instead write down that long type name every time?
There was a problem hiding this comment.
I see that you do have the alias as map_type, so why not use that here?!
include/pini/pini.hpp
Outdated
| @@ -35,6 +43,13 @@ class pini { | |||
| static void default_callback(std::string_view msg, severity level); | |||
| inline static on_msg on_msg_t = &default_callback; | |||
|
|
|||
| bool is_empty(); | |||
include/pini/pini.hpp
Outdated
| @@ -35,6 +43,13 @@ class pini { | |||
| static void default_callback(std::string_view msg, severity level); | |||
| inline static on_msg on_msg_t = &default_callback; | |||
|
|
|||
| bool is_empty(); | |||
| std::size_t size(); | |||
src/pini.cpp
Outdated
| @@ -89,4 +89,11 @@ void pini::default_callback(std::string_view msg, severity level) { | |||
| out << msg << '\n'; | |||
| } | |||
|
|
|||
| bool pini::is_empty() { return key_value_pairs.empty(); } | |||
| std::size_t pini::size() { return key_value_pairs.size(); } | |||
There was a problem hiding this comment.
You may want to inline is_empty() and size() (implement in header / in class definition)
| if (!pin.load_file(filename)) { return 1; } | ||
| for (auto& pair : pin) { std::cout << pair.first << " " << pair.second << '\n'; } | ||
| std::cout << pin.size() << " | " << pin.is_empty(); | ||
| pin.erase("def"); |
There was a problem hiding this comment.
This needs more failure cases. Like I said before, you aren't going to see any output in automated runs.
karnkaul
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
piniclass that uses the iterator built intostd::unordered_mapstd::unordered_map'sempty(),size()clear()anderase()