Added error messages #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll submit my review tomorrow, there are a few edge cases that I want to test |
karnkaul
reviewed
Jul 8, 2021
| @@ -65,7 +81,20 @@ std::int32_t pini::get_int32(std::string const& key, std::uint32_t def) const { | |||
|
|
|||
| std::string_view pini::get_string(std::string const& key) const { | |||
| auto it = key_value_pairs.find(key); | |||
| if (it == key_value_pairs.end()) { return {}; } | |||
| if (it == key_value_pairs.end()) { | |||
| if (pn::pini::on_msg_t) { | |||
There was a problem hiding this comment.
Are you ok with repeating this pattern every time you need to log stuff? There are ways to make it more succinct.
| } | ||
| return ret; | ||
| } | ||
|
|
||
| std::unordered_map<std::string, std::string> insert_pairs(std::vector<std::string> file_lines) { | ||
| std::unordered_map<std::string, std::string> key_value_pairs; | ||
|
|
||
| std::size_t line_number = 0; |
There was a problem hiding this comment.
Nice, you used size_t and not int
| // std::filesystem::path filename{"/test/test.ini"}; | ||
| if (!pin.load_text(raw_input)) { return 1; } | ||
| if (pin.get_int32("a") != 5) { return 1; } |
| if (pin.get_int32("a") != 5) { return 1; } | ||
| std::cout << pin.get_int32("a"); | ||
| std::cout << pin.get_int32("b"); | ||
| std::cout << pin.get_int32("c"); |
There was a problem hiding this comment.
I'd put some more failure cases instead of just printing stuff: you won't see these logs via ctest / through CI etc.
karnkaul
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
#which can be considered comments are ignored