Skip to content

Port present semaphore sync fix to main #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 11, 2025
Merged

Port present semaphore sync fix to main #26

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3f6e27a
🐛 Fix present semaphore sync (#25)
karnkaul May 11, 2025
91fd1b9
Merge branch 'section/rendering' into section/dear-imgui
karnkaul May 11, 2025
506bbc1
Merge branch 'section/dear-imgui' into 'section/shader-objects`
karnkaul May 11, 2025
73eeb37
Merge branch 'section/shader-objects' into section/memory-allocation
karnkaul May 11, 2025
f4a23ba
Port sync fixes to main
karnkaul May 11, 2025
62080d8
Fixup guide
karnkaul May 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixup guide
  • Loading branch information
@karnkaul
karnkaul committed May 11, 2025
commit 62080d8a798552be0d917f915c8b618abfb68491
2 changes: 1 addition & 1 deletion guide/src/rendering/dynamic_rendering.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ void App::submit_and_present() {
wait_semaphore_info.setSemaphore(*render_sync.draw)
.setStageMask(vk::PipelineStageFlagBits2::eColorAttachmentOutput);
auto signal_semaphore_info = vk::SemaphoreSubmitInfo{};
signal_semaphore_info.setSemaphore(*render_sync.present)
signal_semaphore_info.setSemaphore(m_swapchain->get_present_semaphore())
.setStageMask(vk::PipelineStageFlagBits2::eColorAttachmentOutput);
submit_info.setCommandBufferInfos(command_buffer_info)
.setWaitSemaphoreInfos(wait_semaphore_info)
Expand Down