Add support for cubemaps and skybox #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karnkaul
force-pushed
the
karnage/skybox
branch
from
7782fa7 to
9eedb0b
Compare
Currently not set up to be used in a Scene: will need external resources first.
- Rename `BrowseGltf` to `FileBrowser`. - Incorporate "*.skybox" into browsers and drops. - Use `string_view` for events.
- Use `u` instead of `U` for unsigned literals.
- Remove increment logic from `MaybeFuture` and expose class in thread_pool.hpp. - Add `LoadFuture` with increment logic to gltf_loader.hpp.
karnkaul
force-pushed
the
karnage/skybox
branch
from
a9e47fd to
d5110e9
Compare
- Use `zip_ranges()` instead of `enumerate()` for loading skybox data. - Remove enumerate.hpp from TUs where it's unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.