Skip to content

Refactor SceneResources #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 14, 2022
Merged

Refactor SceneResources #67

merged 2 commits into from
Nov 14, 2022

Conversation

karnkaul
Copy link
Member

@karnkaul karnkaul commented Nov 14, 2022 •
edited
Loading

  • Refactor SceneResources to be a single class providing both array ownership and span views.
  • Make Material a value type.
  • Enable choosing between Lit and Unlit materials on Add.
  • Separate persistent InspectData.
  • Add docs.

@karnkaul
Refactor SceneResources
5e3b44a 
- Make `Material` a value type.
- Enable choosing between Lit and Unlit materials on Add.
- Separate persistent `InspectData`.
@karnkaul
Move ResourceArray to its own header
9d485ca 
 - Add docs.
@karnkaul karnkaul marked this pull request as ready for review November 14, 2022 03:16
@karnkaul karnkaul merged commit e4a2180 into main Nov 14, 2022
@karnkaul karnkaul deleted the karnage/resources branch November 14, 2022 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@karnkaul