Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code quality #35

Closed
wants to merge 26 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
16d294e
Modernize Dockerfile using HEREDOCS syntax
fruzitent Apr 24, 2023
927a941
Move default settings into customizations category
fruzitent Apr 24, 2023
33c8ec4
Don't auto-install extensions, so container can be started offline
fruzitent Apr 24, 2023
757e023
Use named volume for increased performance
fruzitent Apr 24, 2023
1a2872e
Use WSLg to forward X-Server
fruzitent Apr 24, 2023
5a54cca
Update recommended defaults
fruzitent Apr 24, 2023
1243648
Use .json as .yml requires additional dependencies
fruzitent Apr 24, 2023
f35188a
Rename LICENSE to LICENSE.md
fruzitent Apr 24, 2023
430583f
Update .gitignore
fruzitent Apr 24, 2023
b47738a
LGTM is deprecated as of August 2022
fruzitent Apr 24, 2023
7c9e063
Remove inline HTML from .md
fruzitent Apr 24, 2023
7e59444
Update Dockerfile
fruzitent Apr 25, 2023
0c802b7
Fix header resolution for clangd
fruzitent Apr 25, 2023
1a4017c
Update README.md
fruzitent Apr 25, 2023
c899b39
Compatibility fix for codespaces
fruzitent Apr 26, 2023
0e4114a
apply formatting, may need some additional changes
fruzitent Apr 26, 2023
672392b
Update configuration files
fruzitent Apr 26, 2023
8544cfa
fix "expected expression" compilation error
fruzitent Apr 26, 2023
31432b1
Pre-Build Dev Container
fruzitent Apr 26, 2023
a724803
Update Dockerfile
fruzitent Apr 28, 2023
49d5bbc
Merge branch 'cpp-best-practices:main' into main
fruzitent Apr 29, 2023
5416094
NOLINT only specific checks
fruzitent Apr 29, 2023
38960d4
Simplify clang-format
fruzitent Apr 29, 2023
20588ec
Update clang-format
fruzitent Apr 29, 2023
c2ca43b
Merge remote-tracking branch 'upstream/main'
fruzitent Apr 29, 2023
33d2b90
Update workflows
fruzitent Apr 30, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'upstream/main'
  • Loading branch information
fruzitent committed Apr 29, 2023
commit c2ca43b6a341554c197cce99bf84e872dd8c5a70
30 changes: 15 additions & 15 deletions .github/workflows/auto-clang-format.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,18 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- uses: DoozyX/clang-format-lint-action@v0.13
with:
source: "."
exclude: "./third_party ./external"
extensions: "h,cpp,hpp"
clangFormatVersion: 12
inplace: True
- uses: EndBug/add-and-commit@v4
with:
author_name: Clang Robot
author_email: robot@example.com
message: ":art: Committing clang-format changes"
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- uses: actions/checkout@v3
- uses: DoozyX/clang-format-lint-action@v0.13
with:
source: '.'
exclude: './third_party ./external'
extensions: 'h,cpp,hpp'
clangFormatVersion: 12
inplace: True
- uses: EndBug/add-and-commit@v4
with:
author_name: Clang Robot
author_email: robot@example.com
message: ':art: Committing clang-format changes'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
12 changes: 6 additions & 6 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
- ON

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Setup Cache
uses: ./.github/actions/setup_cache
Expand All @@ -57,11 +57,11 @@ jobs:
packaging_maintainer_mode: ${{ matrix.packaging_maintainer_mode }}
generator: ${{ matrix.generator }}

- name: Setup Cpp
uses: aminya/setup-cpp@v1
with:
compiler: ${{ matrix.compiler }}
vcvarsall: ${{ contains(matrix.os, 'windows' )}}
- name: Project Name
uses: cardinalby/export-env-action@v2
with:
envFile: '.github/constants.env'


cmake: true
ninja: true
Expand Down
13 changes: 11 additions & 2 deletions .github/workflows/template-janitor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,13 @@ jobs:
gcovr: false
opencppcoverage: false

- name: Project Name
uses: cardinalby/export-env-action@v2
with:
envFile: '.github/constants.env'



- name: Test simple configuration to make sure nothing broke
run: |
cmake -S . -B ./build -G "${{ matrix.generator }}" -DCMAKE_BUILD_TYPE:STRING=${{ matrix.build_type }} -D${{ env.NEW_SAFE_PROJECT }}_PACKAGING_MAINTAINER_MODE:BOOL=ON
Expand All @@ -133,7 +140,8 @@ jobs:
add: -A
author_name: Template Janitor
author_email: template.janitor@example.com
message: "Cleanup template and initialize repository"
message: 'Cleanup template and initialize repository'
pathspec_error_handling: exitImmediately
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Expand Down Expand Up @@ -226,6 +234,7 @@ jobs:
add: -A
author_name: Template Janitor
author_email: template.janitor@example.com
message: "Change Template Name"
message: 'Change Template Name'
pathspec_error_handling: exitImmediately
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
7 changes: 0 additions & 7 deletions ProjectOptions.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,6 @@ include(cmake/LibFuzzer.cmake)
include(CMakeDependentOption)
include(CheckCXXCompilerFlag)

macro(myproject_setup_options)
option(myproject_ENABLE_HARDENING "Enable hardening" ON)
option(myproject_ENABLE_COVERAGE "Enable coverage reporting" OFF)
cmake_dependent_option(
myproject_ENABLE_GLOBAL_HARDENING "Attempt to push hardening options to built dependencies" ON
myproject_ENABLE_HARDENING OFF
)

macro(myproject_supports_sanitizers)
if((CMAKE_CXX_COMPILER_ID MATCHES ".*Clang.*" OR CMAKE_CXX_COMPILER_ID MATCHES ".*GNU.*") AND NOT WIN32)
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.