Skip to content

[basic.life] Move definition of "before" and "after" from last paragraph #6061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

AlisdairM
Copy link
Contributor

The last paragraph of this subclause changes the definition of English words used throughout the preceding paragraphs. While it might be preferable to replace all such usage with the new definitions, that would be a Core issue, see paragraph 6 for an example of awkward usage. Hence, we move the redefinition to the start of the subclause so we know how to read this text from the start.

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 9, 2023

But if we move ths wording up, the note is a bit premature.

@jensmaurer, thoughts? It is ineed weird to only define the terms "before" and "after" at the very end.

@wg21bot wg21bot added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Apr 16, 2024
@AlisdairM AlisdairM force-pushed the AlisdairM-patch-1 branch from b4c0af4 to 8268a3e Compare July 30, 2024 20:52
@AlisdairM
Copy link
Contributor Author

Rebase and force-pushed.
I also moved the now-misplaced comment to a more appropriate paragraph.

@AlisdairM
Copy link
Contributor Author

How do I remove the "needs rebase" tag?

@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 5, 2024

You don't -- just let us know that you've rebased.

@tkoeppe tkoeppe removed the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Aug 5, 2024
…f subclause

The last paragraph of this subclause changes the definition of English words
used throughout the preceding paragraphs.  While it might be preferable
to replace all such usage with the new definitions, that would be a Core issue,
see paragraph 6 for an example of awkward usage.  Hence, we move the
redefinition to the start of the subclause so we know how to read this text
from the start.
@AlisdairM
Copy link
Contributor Author

Rebased onto main again, and fixed an accidentally moved \indextext that delimited the end of a section. Force-pushed.

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 19, 2024

OK, never mind, this is fine.

@tkoeppe tkoeppe merged commit a05b963 into cplusplus:main Nov 19, 2024
2 checks passed
@AlisdairM AlisdairM deleted the AlisdairM-patch-1 branch November 19, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants