Motions 2022 11 lwg 9 #5995
Merged
Motions 2022 11 lwg 9 #5995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@jwakely: Could you please take a look at the added note (see second commit)? |
jwakely
approved these changes
Nov 21, 2022
Member
jwakely
left a comment
jwakely
left a comment
There was a problem hiding this comment.
The new note for [concept.swappable] is a good idea. LGTM.
JohelEGP
approved these changes
Nov 22, 2022
Fixes NB US 111 (C++23 CD).
tkoeppe
force-pushed
the
motions-2022-11-lwg-9
branch
from
ad48ab8 to
12440ca
Compare
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P2602R2 Poison Pills are Too Toxic
Fixes #5970.
Also fixes cplusplus/papers#1266.
Also fixes https://github.com/cplusplus/nbballot/issues/526.
Also: Following discussion with @brevzin and @tkoeppe, added an extra note explaining why
swappoison pill is still needed.