Skip to content

[Motions 2022 11 lwg 8] P2704R0 C++ Standard Library Immediate Issues #5982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Dec 15, 2022
Merged

[Motions 2022 11 lwg 8] P2704R0 C++ Standard Library Immediate Issues #5982

merged 14 commits into from
Dec 15, 2022

Conversation

@burblebee
Copy link
Contributor

@burblebee burblebee commented Nov 17, 2022 •
edited by jensmaurer
Loading

Fixes #5969.
Fixes cplusplus/papers#1393
Fixes cplusplus/papers#1298
Fixes cplusplus/nbballot#507
Partially addresses cplusplus/nbballot#524
Fixes cplusplus/nbballot#448
Fixes cplusplus/nbballot#440
Fixes cplusplus/nbballot#439
Partially addresses cplusplus/nbballot#442
Fixes cplusplus/nbballot#519
Fixes cplusplus/nbballot#456
Fixes cplusplus/nbballot#435
Fixes cplusplus/nbballot#449
Fixes cplusplus/nbballot#437
Fixes cplusplus/nbballot#531
Fixes cplusplus/nbballot#538

@burblebee burblebee marked this pull request as draft November 17, 2022 06:17
@burblebee burblebee force-pushed the motions-2022-11-lwg-8 branch from 357e1e9 to 0cacf24 Compare November 18, 2022 18:24
@burblebee burblebee marked this pull request as ready for review November 18, 2022 18:53
JohelEGP
JohelEGP suggested changes Nov 19, 2022
View reviewed changes
Copy link
Contributor

@JohelEGP JohelEGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LWG3817 LWG3818 LWG3826 are not part of P2704R0. I reviewed them nonetheless.

timsong-cpp
timsong-cpp reviewed Nov 19, 2022
View reviewed changes
@timsong-cpp
Copy link
Contributor

timsong-cpp commented Nov 19, 2022

LWG3817 LWG3818 LWG3826 are not part of P2704R0.

They are in the version attached to the wiki. @jwakely - I guess the paper tracking system need to be updated?

@jwakely
Copy link
Member

jwakely commented Nov 20, 2022

Oops yes, I didn't put the latest version on isocpp.org

@jwakely
Copy link
Member

jwakely commented Nov 20, 2022

The document on isocpp.org has been updated to match what we voted on in Kona.

@burblebee
Copy link
Contributor Author

burblebee commented Nov 22, 2022 •
edited
Loading

LWG3817 LWG3818 LWG3826 are not part of P2704R0. I reviewed them nonetheless.

What paper are you looking at? They're in the document I'm looking at from the straw polls (https://wiki.edg.com/pub/Wg21kona2022/StrawPolls/p2704r0.html?twiki_redirect_cache=8ee3b437fe2dbe928dd162d653e0e49a).

Oh I see, please update the paper in the straw polls (at https://wiki.edg.com/bin/view/Wg21kona2022/StrawPolls). What's the link to the iosocpp copy?

@JohelEGP
Copy link
Contributor

JohelEGP commented Nov 22, 2022

I used https://wg21.link/P2704R0.

@burblebee
Copy link
Contributor Author

burblebee commented Nov 22, 2022 •
edited
Loading

What's supposed to be the "official" paper that we use for the motions? I'm using the ones linked in the strawpolls themselves since my understanding is that that is what was voted on. If that paper was out of date, then the people that voted on the older version may object to having things change out from underneath them.

@tkoeppe what to do here? Should I remove LWG3817 LWG3818 LWG3826 and force-push?

@burblebee
Copy link
Contributor Author

burblebee commented Nov 22, 2022

Ok... I think folks are saying that the copy in the strawpolls is the correct one, right? So LWG3817 LWG3818 LWG3826 are supposed to be in.

@burblebee burblebee requested a review from JohelEGP November 22, 2022 04:42
@jwakely
Copy link
Member

jwakely commented Nov 22, 2022

Ok... I think folks are saying that the copy in the strawpolls is the correct one, right? So LWG3817 LWG3818 LWG3826 are supposed to be in.

Yes. They're in https://wg21.link/P2704R0 now anyway, it's been updated to match the one we voted on.

@burblebee @tkoeppe
LWG3515 §[stacktrace.basic.nonmem]: operator<< should be less templat…
86a1ffc 
…ized
@burblebee @tkoeppe
LWG3569 join_view fails to support ranges of ranges with non-default_…
871cf97 
…initializable iterators
@burblebee @tkoeppe
LWG3717 common_view::end should improve random_access_range case
e38d521 
Partially fixes NB US 109 (C++23 CD).
@burblebee @tkoeppe
LWG3737 take_view::sentinel should provide operator-
7583485 
Partially fixes NB US 109 (C++23 CD).
@burblebee @tkoeppe
LWG3753 Clarify entity vs. freestanding entity
863a4c2 
Fixes NB GB 075 (C++23 CD).
@burblebee @tkoeppe
LWG3766 view_interface::cbegin is underconstrained
abe6947
@burblebee @tkoeppe
LWG3814 Add freestanding items requested by NB comments
d4e29f5 
Fixes NB GB 085, GB 110, (partially) GB 130 (C++23 CD).
@burblebee @tkoeppe
LWG3816 flat_map and flat_multimap should impose sequence container r…
4086402 
…equirements

Fixes NB US 103 (C++23 CD).
@burblebee @tkoeppe
LWG3817 Missing preconditions on forward_list modifiers
10b8762 
Fixes NB GB 101 (C++23 CD).
@burblebee @tkoeppe
LWG3818 Exposition-only concepts are not described in library intro
29aeaf5 
Fixes NB GB 074 (C++23 CD).
@burblebee @tkoeppe
LWG3822 Avoiding normalization in filesystem::weakly_canonical
6163fa7 
Fixes NB US 125 (C++23 CD).
@burblebee @tkoeppe
LWG3823 Unnecessary precondition for is_aggregate
cc63fcd 
Fixes NB GB 090 (C++23 CD).
@burblebee @tkoeppe
LWG3824 Number of bind placeholders is underspecified
a3204c4 
Fixes NB GB 95 (C++23 CD).
@burblebee @tkoeppe
LWG3826 Redundant specification [for overload of yield_value]
60fb503 
Fixes NB US 118 (C++23 CD).
@tkoeppe tkoeppe force-pushed the motions-2022-11-lwg-8 branch from 7f82a4b to 60fb503 Compare December 15, 2022 14:34
@tkoeppe tkoeppe merged commit ff2298e into main Dec 15, 2022
@tkoeppe tkoeppe deleted the motions-2022-11-lwg-8 branch May 10, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jwakely jwakely jwakely approved these changes

+2 more reviewers

@timsong-cpp timsong-cpp timsong-cpp left review comments

@JohelEGP JohelEGP JohelEGP approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

6 participants

@burblebee @timsong-cpp @jwakely @JohelEGP @tkoeppe