[range.join.view] remove duplicative condition in end() const #4957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is constrained on `is_reference_v<range_reference_t<const V>>` already so checking it again in the `if constexpr` has no effect.
jensmaurer
approved these changes
Oct 2, 2021
There was a problem hiding this comment.
Looks good to me.
@jwakely , @CaseyCarter , a second opinion, please.
CaseyCarter
approved these changes
Oct 4, 2021
CaseyCarter
added a commit
to CaseyCarter/STL
that referenced
this pull request
Oct 5, 2021
Drive-by: Drop extraneous `if constexpr` condition in `join_view::end` as suggested by cplusplus/draft#4957.
CaseyCarter
added a commit
to CaseyCarter/STL
that referenced
this pull request
Oct 5, 2021
Drive-by: Drop extraneous `if constexpr` condition in `join_view::end` as suggested by cplusplus/draft#4957. Fixes microsoft#2240
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is constrained on
is_reference_v<range_reference_t<const V>>already so checking it again in theif constexprhas no effect.