Skip to content

Add support for DataModelCodegen Output #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ikelax
Copy link
Contributor

@ikelax ikelax commented Mar 19, 2025

Closes #189.

Changes

Add a capture group for the DataModelCodegen output.

Testing

  • Added new unit tests

@ikelax
Copy link
Contributor Author

ikelax commented Mar 19, 2025

I will add tests soon.

ikelax added 3 commits March 19, 2025 18:55
formatDataModelCodegen returns a String and not a String Optional.
@ikelax ikelax marked this pull request as ready for review March 19, 2025 19:02
@ikelax ikelax requested a review from cpisciotta as a code owner March 19, 2025 19:02
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.51%. Comparing base (6a3819d) to head (901b6ef).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
+ Coverage   91.46%   91.51%   +0.04%     
==========================================
  Files          18       18              
  Lines        2508     2521      +13     
==========================================
+ Hits         2294     2307      +13     
  Misses        214      214              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Owner

@cpisciotta cpisciotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @ikelax! Made a couple of formatting changes, and releasing in 2.28.0.

@cpisciotta cpisciotta merged commit ac16b51 into cpisciotta:main Mar 31, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Output] Support DataModelCodegen Output
2 participants