fix: POD documentation errors and BIGNUM memory leak on OpenSSL 3.x #74
+4
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix self-referencing typo in new_public_key docs: "use_pkcs1_pss_padding (or use_pkcs1_pss_padding)" → single reference with proper C<> POD formatting - Fix "Version 0.38" reference (unreleased) → "On OpenSSL 3.x" to accurately describe when automatic padding selection applies - Fix is_private docs: "false if it is private only" → "public only" - Fix BIGNUM memory leak in generate_key on OpenSSL 3.x: `e = NULL; BN_free(e)` was a no-op, leaking the BIGNUM allocated by BN_new(). The set1 semantics of EVP_PKEY_CTX_set1_rsa_keygen_pubexp copy the value, so the caller must still free the original. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
atoomic
reviewed
Feb 11, 2026
| =item is_private | ||
|
|
||
| Return true if this is a private key, and false if it is private only. | ||
| Return true if this is a private key, and false if it is public only. |
atoomic
reviewed
Feb 11, 2026
| CHECK_OPEN_SSL(EVP_PKEY_generate(ctx, &rsa) == 1); | ||
| CHECK_OPEN_SSL(rsa != NULL); | ||
|
|
||
| e = NULL; |
Collaborator
There was a problem hiding this comment.
nice catch too, why setting it to null before calling free?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
new_public_keyPOD: "use_pkcs1_pss_padding (or use_pkcs1_pss_padding)" → single reference with properC<>formattingis_privatePOD: "false if it is private only" → "false if it is public only"generate_keyon OpenSSL 3.x:e = NULL; BN_free(e)was a no-op (BN_free(NULL) does nothing), leaking the BIGNUM allocated byBN_new(). Theset1semantics ofEVP_PKEY_CTX_set1_rsa_keygen_pubexpcopy the value internally, so the caller must still free the original.Changes
RSA.pm— 3 POD documentation fixesRSA.xs— Removee = NULLbeforeBN_free(e)in OpenSSL 3.xgenerate_keypathTest plan
make test— all 214 tests passset1copy semantics: caller retains ownership, must freeBN_free(e)🤖 Generated with Claude Code