Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on a hermes fork to pass custom template functions #1148

Merged
merged 1 commit into from
Jan 4, 2018

Conversation

jinroh
Copy link
Contributor

@jinroh jinroh commented Jan 4, 2018

This is mainly done in order to fix the go.uuid API breaking changes, since hermes rely on sprig which rely on this library.

We should introduce quickly the new go dep tool in order to lock our dependencies and avoid these kind of issues in the near future.

@jinroh jinroh requested a review from nono January 4, 2018 11:36
@codecov-io
Copy link

codecov-io commented Jan 4, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@506dd03). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1148   +/-   ##
========================================
  Coverage          ?   84.9%           
========================================
  Files             ?     178           
  Lines             ?   52330           
  Branches          ?       0           
========================================
  Hits              ?   44429           
  Misses            ?    6470           
  Partials          ?    1431
Impacted Files Coverage Δ
pkg/workers/mails/mail_templates.go 93.35% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 506dd03...58e4540. Read the comment docs.

@jinroh jinroh merged commit 5190adf into cozy:master Jan 4, 2018
@jinroh jinroh deleted the hermes branch January 4, 2018 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants