fix: Promise.finally() is not supported on FF even with babel polyfills

cozy · Jan 5, 2018 · a43e28e · a43e28e
1 parent 3472238
commit a43e28e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/.babelrc b/.babelrc
@@ -5,7 +5,8 @@
         "chrome": 42,
         "browsers": ["last 2 versions"]
       },
-      "useBuiltIns": true
+      "useBuiltIns": true,
+      "shippedProposals": true
     }],
     "react"
   ],

diff --git a/src/sharing/components/ShareByEmail.jsx b/src/sharing/components/ShareByEmail.jsx
@@ -161,14 +161,18 @@ class ShareByEmail extends Component {
             count: recipients.length
           })
         }
+        this.reset()
       })
       .catch(err => {
         Alerter.error('Error.generic')
-        throw err
-      })
-      .finally(() => {
         this.reset()
+        throw err
       })
+    // TODO: We'd like to use finally here but unfortunately it doesn't work on FF
+    // even with the `shippedProposals` option to babel-preset-env
+    // .finally(() => {
+    //   this.reset()
+    // })
   }
 
   render() {