tech: Reduce amount of logs written to disk #2356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taratatach
changed the title
taratatach
force-pushed
the
tech/remove-some-logs
branch
2 times, most recently
from
976fb83
to
813ff8b
Compare
Base automatically changed from
fix/require-flags-module-in-gui-via-electron-remote
to
master
October 30, 2024 15:29
Since logging often decreases app performance, we reduce the amount of lines we write in normal conditions by changing the level of logging statement called often to `debug` or `trace` and changing the level of written lines to `info`. We also make sure important information is logged with the `info` level at the minimum so they get written.
Since we've decreased the amount of logs written to disk, we might miss some important information to help debug user issues. By allowing to re-enable `trace` level logging via a (remote) flag, we give ourselves a chance to get more details about long standing issues.
taratatach
force-pushed
the
tech/remove-some-logs
branch
from
813ff8b
to
5047a6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since logging often decreases app performance, we reduce the amount of
lines we write in normal conditions by changing the level of logging
statement called often to
debugortraceand changing the level ofwritten lines to
info.We also make sure important information is logged with the
infolevel at the minimum so they get written.
Since we decrease the amount of logs written to disk, we might miss some
important information to help debug user issues and thus add the
possibility to re-enable
tracelevel logging via a (remote) flag.Please make sure the following boxes are checked: